ci: add Linux ARM and macOS to GitHub Actions#855
Open
zaidoon1 wants to merge 1 commit intocloudflare:mainfrom
Open
ci: add Linux ARM and macOS to GitHub Actions#855zaidoon1 wants to merge 1 commit intocloudflare:mainfrom
zaidoon1 wants to merge 1 commit intocloudflare:mainfrom
Conversation
f614b8b to
6cf1993
Compare
Add an OS dimension to the matrix so the full toolchain suite (nightly, MSRV, stable) runs on Linux x86, Linux ARM64, and macOS. Dependency install is gated on runner.os; the macOS leg taps openresty/brew, drops the unavailable GeoIP nginx module, and adds a 127.0.0.2 lo0 alias so loopback-binding tests work. The mock origin in pingora-proxy is invoked with an explicit -c nginx.conf path because openresty's macOS layout differs from Linux. The flaky pingora-limits rate test (test_observe_rate_custom_proportional) relies on tight epsilons that are too noisy on the macOS GitHub runner, so it is gated to target_os = "linux".
b41dd70 to
84db1fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add os dimension to the matrix so the full toolchain suite (nightly, MSRV, stable) runs on Linux x86, Linux ARM64, and macOS. Dependency install is gated on runner.os.