Consolidate template versions#5228
Open
bfops wants to merge 7 commits into
Open
Conversation
…origin/master' into bfops/consolidate-template-versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
It turns out that different templates have different behavior for whether they get a major+minor version constraint, a major+minor+patch version constraint, or, surprisingly, just a major version constraint. See #5229 for a bit more detail.
This PR brings them all in line to major+minor.
This fixes a bug where we could release a newer version of the server+CLI, but not the crates, and that would cause the CLI to initialize some templates to expect a version number that did not exist.
I am not 100% sure that this doesn't have surprise consequences, since this is a weird situation in the first place.
API and ABI breaking changes
None
Expected complexity level and risk
2
Testing
spot tests, but more importantly some template smoketests have been added to check that the version constraints are now
major.minoron some representative templates.