-
Notifications
You must be signed in to change notification settings - Fork 453
chore(clerk-js,ui): Make OAuthConsent component public #8381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
69dac72
docs: add accounts portal OAuth consent refactor spec
wobsoriano 2c33684
feat: promote OAuthConsent to public API across all SDKs
wobsoriano c7c79fa
chore: add changeset
wobsoriano 39afe25
chore: fix deprecation
wobsoriano 5adabce
Merge branch 'main' into rob/oauth-consent-ga
wobsoriano 0f340a8
chore: add back internal methods
wobsoriano b660e28
chore: fix type tests
wobsoriano 3b8d7bf
fix: snapshot exports tests
wobsoriano 24a419f
chore: update changesets
wobsoriano bf70ca2
chore: use stable methods for unpublished sdks
wobsoriano 7dd33d6
Merge branch 'main' into rob/oauth-consent-ga
wobsoriano d0245bf
Merge branch 'main' into rob/oauth-consent-ga
alexcarpenter 23cdb69
chore: remove tanstack and react-router internal exports
wobsoriano 54475bd
Merge branch 'main' into rob/oauth-consent-ga
wobsoriano 82c74ac
chore: update changeset
wobsoriano 058b474
fix lint issues
wobsoriano 7f6f1de
Merge branch 'main' into rob/oauth-consent-ga
jacekradko b4030c7
Merge branch 'main' into rob/oauth-consent-ga
wobsoriano fe96c4a
fix lint issues
wobsoriano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| --- | ||
| "@clerk/nuxt": minor | ||
| "@clerk/vue": minor | ||
| --- | ||
|
|
||
| Expose `OAuthConsent` as a public component export for Vue and Nuxt. | ||
|
|
||
| Example: | ||
|
|
||
| ```vue | ||
| <script setup lang="ts"> | ||
| import { OAuthConsent } from '@clerk/vue'; | ||
| </script> | ||
|
|
||
| <template> | ||
| <OAuthConsent /> | ||
| </template> | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| --- | ||
| "@clerk/astro": minor | ||
| --- | ||
|
|
||
| Expose `OAuthConsent` as a public component export for Astro. | ||
|
|
||
| Example: | ||
|
|
||
| ```astro | ||
| --- | ||
| import { OAuthConsent } from '@clerk/astro/components'; | ||
| --- | ||
|
|
||
| <OAuthConsent /> | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| --- | ||
| "@clerk/clerk-js": minor | ||
| "@clerk/nextjs": minor | ||
| "@clerk/react": minor | ||
| "@clerk/react-router": minor | ||
| "@clerk/shared": minor | ||
| "@clerk/tanstack-react-start": minor | ||
| "@clerk/ui": minor | ||
| --- | ||
|
|
||
| Expose `OAuthConsent` as a public component export across React-based SDKs. | ||
|
|
||
| Example: | ||
|
|
||
| ```tsx | ||
| import { OAuthConsent } from '@clerk/react'; | ||
|
|
||
| export default function Page() { | ||
| return <OAuthConsent />; | ||
| } | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
packages/astro/src/astro-components/interactive/OAuthConsent.astro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| import type { OAuthConsentProps } from '@clerk/shared/types'; | ||
| type Props = OAuthConsentProps; | ||
| import InternalUIComponentRenderer from './InternalUIComponentRenderer.astro'; | ||
| --- | ||
|
|
||
| <InternalUIComponentRenderer | ||
| {...Astro.props} | ||
| component='oauth-consent' | ||
| /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: clerk/javascript
Length of output: 403
Add explicit return type annotations to the new public OAuth consent methods.
Lines 1302 and 1306 introduce public API methods without explicit return type annotations. Declare
: voidto match existing methods in the same file (mountAPIKeys,unmountAPIKeys) and comply with the guideline requiring explicit return types for public APIs.Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents