Change parameter order for docker-no-tty.#25
Merged
Conversation
Signed-off-by: D. Mitch Bailey <d.mitch.bailey@gmail.com>
Contributor
|
That makes it always run in dockerized mode, right? |
Contributor
Author
|
@marwaneltoukhy these changes don't effect the determination to run in nix or docker. The only change is to the order of the options when calling librelane when using docker if there is no tty. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cf hardenfails when dockerized and disconnected from a tty (eg. during git hub ci)This change corrects the parameter order and runs without an error.
@marwaneltoukhy @jeffdi