Skip to content

Change parameter order for docker-no-tty.#25

Merged
marwaneltoukhy merged 1 commit into
chipfoundry:mainfrom
d-m-bailey:docker-no-tty-fix
May 12, 2026
Merged

Change parameter order for docker-no-tty.#25
marwaneltoukhy merged 1 commit into
chipfoundry:mainfrom
d-m-bailey:docker-no-tty-fix

Conversation

@d-m-bailey
Copy link
Copy Markdown
Contributor

cf harden fails when dockerized and disconnected from a tty (eg. during git hub ci)

$ cf harden --use-docker user_proj_example </dev/null
Fetching version information from cf-cli repository...
✓ Version information loaded successfully

============================================================
Hardening: user_proj_example
Config: config.json
Run tag: 26_05_11_18_46
PDK: sky130A
PDK Root: /mnt/designs/bailey/github/caravel_user_project/dependencies/pdks
Execution: Docker
============================================================

Running LibreLane via Docker on user_proj_example...
WARNING: This output is designed for human readability. For machine-readable output, please use --format.
[18:46:36] WARNING  DISPLAY environment variable not set. GUI features will not be available.     container.py:53
[18:46:36] INFO     Running containerized command:                                               container.py:285
/usr/bin/docker run --rm --name 17c91cbe-b64a-49e0-b88f-59f121b15f6e -i -t --user 1004:140 -v /home/bailey:/home/bailey -v /home/bailey/.ciel:/home/bailey/.ciel -e PDK_ROOT=/home/bailey/.ciel -v /mnt/designs/bailey/github/caravel_user_project/openlane:/mnt/designs/bailey/github/caravel_user_project/openlane -w /mnt/designs/bailey/github/caravel_user_project/openlane -v /mnt/designs/bailey/github/caravel_user_project:/mnt/designs/bailey/github/caravel_user_project -v /mnt/designs/bailey/github/caravel_user_project/dependencies/pdks:/mnt/designs/bailey/github/caravel_user_project/dependencies/pdks ghcr.io/librelane/librelane:2.4.6 python3 -m librelane --docker-no-tty --manual-pdk --pdk-root /mnt/designs/bailey/github/caravel_user_project/dependencies/pdks --pdk sky130A --ef-save-views-to /mnt/designs/bailey/github/caravel_user_project --run-tag 26_05_11_18_46 --overwrite /mnt/designs/bailey/github/caravel_user_project/openlane/user_proj_example/config.json
cannot attach stdin to a TTY-enabled container because stdin is not a terminal

✗ Hardening failed with exit code 1

This change corrects the parameter order and runs without an error.

@marwaneltoukhy @jeffdi

Signed-off-by: D. Mitch Bailey <d.mitch.bailey@gmail.com>
@marwaneltoukhy
Copy link
Copy Markdown
Contributor

That makes it always run in dockerized mode, right?

@d-m-bailey
Copy link
Copy Markdown
Contributor Author

@marwaneltoukhy these changes don't effect the determination to run in nix or docker.

The only change is to the order of the options when calling librelane when using docker if there is no tty.

@marwaneltoukhy marwaneltoukhy merged commit 5decfe6 into chipfoundry:main May 12, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants