feedbackOnStatus: Use format for everything

[isomorpheme]

Depends on #272 (just because that function got touched there; rebasing later would be a pain).

[musicismyalibi]

LGTM, you could consider also doing line 482 while you're at it.

[robbert-vdh]

Just FYI, Text.Format is a big footgun, and I'd avoid it for anything somehwat mission critical (or in general). If the length o the list doesn't match the number of placeholders, then this call will diverge, which could end up taking the entire service down.

[isomorpheme]

Just FYI, Text.Format is a big footgun, and I'd avoid it for anything somehwat mission critical (or in general). If the length o the list doesn't match the number of placeholders, then this call will diverge, which could end up taking the entire service down.

Thanks for pointing this out! I've created #275 to completely get rid of it then.

[isomorpheme]

@OpsBotPrime merge

[OpsBotPrime]

Pull request approved for merge by @isomorpheme, rebasing now.

[OpsBotPrime]

Failed to rebase, please rebase manually using

git fetch && git rebase --interactive --autosquash origin/master refactor-use-format

[isomorpheme]

@OpsBotPrime merge

[OpsBotPrime]

Pull request approved for merge by @isomorpheme, rebasing now.

[OpsBotPrime]

Rebased as 82ebfd6, waiting for CI …

[OpsBotPrime]

CI job 🟡 started.