Skip to content

Make a comment less likely to bitrot#16

Open
isomorpheme wants to merge 1 commit into
masterfrom
outdated-comment
Open

Make a comment less likely to bitrot#16
isomorpheme wants to merge 1 commit into
masterfrom
outdated-comment

Conversation

@isomorpheme

Copy link
Copy Markdown

The NixOS version and date in there are not accurate anymore (we're requiring curl from a much newer nixpkgs) and are annoying to update, so this changes the comment to be more generic, and communicate the actual intent behind doing this assertion (which I've inferred from PRs like #8).

@FPtje FPtje left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isomorpheme

Copy link
Copy Markdown
Author

@flaizdnag As the most recent person who merged in this repo, would you mind merging this for me? I don't have the permissions, and I don't think we have hoff enabled here. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants