CFE-4639: Removed conflicting --global flag from standard_services systemctl invocation (3.24.x)#3139
Merged
larsewi merged 2 commits intocfengine:3.24.xfrom Apr 27, 2026
Conversation
Contributor
Author
|
@cf-bottom Jenkins please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/13566/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13566/ |
Contributor
Author
|
@cf-bottom Jenkins please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/13589/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13589/ |
The call_systemctl command in the systemd_services bundle passed both --global and --system to systemctl. These flags are mutually exclusive: --global operates on the global user configuration (affecting all users' systemd --user instances), while --system operates on the system manager. Passing both causes systemctl to fail with an error about conflicting options, breaking the default standard_services bundle. Since standard_services manages system services, --system is the correct scope; --global has been removed. Ticket: CFE-4639 Changelog: Title Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech> (cherry picked from commit 052bb8e)
Added with the PR so that if it's not merged, the chagelog isn't stale with a missing entry
nickanderson
force-pushed
the
CFE-4639-remove-global-flag-3.24.x
branch
from
09bf947 to
9ba056e
Compare
Contributor
|
@cf-bottom jenkins |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/13590/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-13590/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
call_systemctlcommand in thesystemd_servicesbundle passed both--globaland--systemtosystemctl. These flags are mutually exclusive:--globaloperates on the global user configuration (affects all users'systemd --userinstances)--systemoperates on the system managerPassing both causes
systemctlto fail with an error about conflicting options, breaking the defaultstandard_servicesbundle.Since
standard_servicesmanages system services,--systemis the correct scope;--globalhas been removed.Backported from #3134