Use ConcurrentDictionary instead of SynchronizedDictionary#744
Closed
Youssef1313 wants to merge 5 commits intocastleproject:masterfrom
Closed
Use ConcurrentDictionary instead of SynchronizedDictionary#744Youssef1313 wants to merge 5 commits intocastleproject:masterfrom
Youssef1313 wants to merge 5 commits intocastleproject:masterfrom
Conversation
Author
|
While trying to write a perf test to this, it looks like the changes here somehow ended up making stuff unstable. Here is the test for reference: It's stable on master but not with this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #743