fix: allow empty generic tag filter values#583
Merged
cameri merged 1 commit intocameri:mainfrom Apr 26, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 1d8c124 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
cameri
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Generic tag filters should be able to match empty tag values like {"#d":[""]}. The matcher/query path already treats empty tag values as normal values, but validation rejected them before matching.
This relaxes generic tag filter validation while keeping ids/authors validation unchanged, and adds schema/runtime coverage.
Related Issue
Fixes #259
Motivation and Context
The schema rejects
{"#d":[""]}withinvalid: "[2].#d[0]" is not allowed to be empty, but the matcher and query path already accept empty tag values. Real events with["d", ""]exist on the network (NIP-23, NIP-58 badges) and other relays accept this filter. This aligns validation with existing behavior.How Has This Been Tested?
pnpm exec mocha test/unit/schemas/filter-schema.spec.ts test/unit/utils/event.spec.ts test/unit/repositories/event-repository.spec.tspnpm build:checkpnpm exec biome lint src/schemas/filter-schema.ts test/unit/schemas/filter-schema.spec.ts test/unit/utils/event.spec.ts test/unit/repositories/event-repository.spec.tsTypes of changes
Checklist: