Develop#14
Open
matthewpeterkort wants to merge 22 commits intomasterfrom
Open
Conversation
* split client out further into more digestable parts * simplify, factor business logic out of cmd package and into upload and download packages * rearrange some more stuff. Start testing * fix some bugs * abstract out token handling into lowest level request interface * fix a bunch of bugs * adds very minimal docs
* fix missing error check * Initial plan * Fix error wrapping to preserve error chain using fmt.Errorf with %w Co-authored-by: bwalsh <47808+bwalsh@users.noreply.github.com> * Update PR description with completion status Co-authored-by: bwalsh <47808+bwalsh@users.noreply.github.com> * Add /bin/ to .gitignore and remove accidentally committed binary Co-authored-by: bwalsh <47808+bwalsh@users.noreply.github.com> --------- Co-authored-by: Brian Walsh <brian@bwalsh.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: bwalsh <47808+bwalsh@users.noreply.github.com>
* MinChunkSize: 10MB * fix:improve-multipart #18 * improve OptimalChunkSize.scaleLinear * adds optimal-chunk-size * table-driven tests GetLfsCustomTransferInt * Address PR review comments: fix naming, formatting, and test coverage * Add logging for git config errors and improve documentation structure * Fix spelling: terrabytes → terabytes * adds ProgressEvent * Fix nil pointer dereferences and duplicate progress events - Added nil check for req.Progress in multipart.go to prevent panic - Removed duplicate progress event in singleFile.go (Finalize already emits) - Fixed concurrent BytesSoFar calculation using atomic counter for monotonicity * adds tests * add noop ProgressCallback
* MinChunkSize: 10MB * fix:improve-multipart #18 * improve OptimalChunkSize.scaleLinear * adds optimal-chunk-size * table-driven tests GetLfsCustomTransferInt * Initial plan * Address PR review comments: fix naming, formatting, and test coverage * Add logging for git config errors and improve documentation structure * Fix spelling: terrabytes → terabytes * refactor a bunch of stuff, incorporate latest commits on develop * add g3client * operational data-client * tests passing * add sower client * fix up logging to pass back to main git-drs logger when configured * addresse logging feedbacks * add requestor client and commands * add command validation for collaborator command * fix up releaser * fix PartNumber typo regression * fix partNumber
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
* fix tests * make progress logging tied to minChunkSize * refactor/add-url #28 * typo * improve onProgress bytesSinceReport >= 1MB * OnProgressThreshold --------- Co-authored-by: matthewpeterkort <matthewpeterkort@gmail.com>
Contributor
|
@matthewpeterkort I think this has been done. If so can you close it? |
Collaborator
Author
|
what you mean by close it ? last merge to main was months ago |
Contributor
|
@matthewpeterkort my mistake, I misread the target |
* start refactor to support non-gen3 file handling backend * continue build out backend for drs server * lock down data-client version * rearrange data client to support drs server * update apigen * add ci * fix tests * add client support for bulk url signing * remove apigen from data-client * fix imports * move sifon client out of data-client into its own package in syfon repo * fix test * demisitify collaborators command
Test Coverage ReportOverall Coverage: 52.9% Package Coverage
|
Test Coverage ReportOverall Coverage: 52.9% Package Coverage
|
Test Coverage ReportOverall Coverage: 55.6% Package Coverage
|
Contributor
Review Steps 🌀1. Install➜ cd data-client
➜ git fetch --all
➜ git checkout develop
➜ git show --summary --oneline
8e9b714 (HEAD -> develop, origin/develop) update data client
➜ make
--> Building data-client...
Build successful! Binary placed in ./bin/data-client
➜ export PATH=$PATH:./bin
➜ which data-client
./bin/data-client
➜ data-client --version
data-client version 2026.22. Configure
Tip
➜ data-client configure --profile=calypr-dev --cred=~/Downloads/credentials.json --apiendpoint=https://calypr-dev.ohsu.edu
Profile 'calypr-dev' has been configured successfully.3. UploadWithout MetadataCaution Currently encountering a
➜ data-client upload --profile=calypr-dev --upload-path=README.md --bucket calypr
level=ERROR msg="Upload failed" path=data-client/README.md error="failed to get upload URL: 405"
level=ERROR msg="Upload failed" error="failed to get upload URL: 405"With Metadata➜ TODO4. Download➜ TODO |
Test Coverage ReportOverall Coverage: 58.6% Package Coverage
|
Test Coverage ReportOverall Coverage: 58.7% Package Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.