Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/dev/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ export type SerializedParametersContainer = z.infer<
>;

export const evaluatorDefinitionSchema = z.object({
parameters: serializedParametersContainerSchema.optional(),
parameters: serializedParametersContainerSchema.nullish(),
scores: z.array(z.object({ name: z.string() })).optional(),
classifiers: z.array(z.object({ name: z.string() })).optional(),
});
Expand Down
35 changes: 34 additions & 1 deletion js/src/zod/zod-v3-serialization.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,10 @@ import {
serializeEvalParametersToStaticParametersSchema,
serializeRemoteEvalParametersContainer,
} from "../framework2";
import { serializedParametersContainerSchema } from "../../dev/types";
import {
serializedParametersContainerSchema,
evaluatorDefinitionSchema,
} from "../../dev/types";
// Detect which zod version is installed by checking for v4-specific properties
function getInstalledZodVersion(): 3 | 4 {
const testSchema = zodModule.z.string();
Expand Down Expand Up @@ -199,3 +202,33 @@ describe("serializedParametersContainerSchema parsing", () => {
expect(result.success).toBe(true);
});
});

describe("evaluatorDefinitionSchema parameters nullish", () => {
test("allows parameters: null", () => {
const result = evaluatorDefinitionSchema.safeParse({
parameters: null,
});
expect(result.success).toBe(true);
if (result.success) {
expect(result.data.parameters).toBeNull();
}
});

test("allows parameters: undefined", () => {
const result = evaluatorDefinitionSchema.safeParse({
parameters: undefined,
});
expect(result.success).toBe(true);
if (result.success) {
expect(result.data.parameters).toBeUndefined();
}
});

test("allows parameters omitted entirely", () => {
const result = evaluatorDefinitionSchema.safeParse({});
expect(result.success).toBe(true);
if (result.success) {
expect(result.data.parameters).toBeUndefined();
}
});
});
Loading