Add .cursorrules link and include more in REVIEW.md about commit series#176
Add .cursorrules link and include more in REVIEW.md about commit series#176cgwalters wants to merge 2 commits intobootc-dev:mainfrom
Conversation
Cursor reads .cursorrules as its agent instruction file. Symlinking it to AGENTS.md keeps a single source of truth rather than maintaining separate files that can drift. Assisted-by: OpenCode (claude-sonnet-4-6@default) Signed-off-by: Colin Walters <walters@verbum.org>
…mmit A recurring pattern, especially with AI-assisted reviews (Gemini, Copilot, etc.), is that applying a suggested fix creates a new commit with a generic auto-generated subject like "Update README.md". That commit should be squashed into the original before merge. Motivated by bootc-dev/bootc#2182. Assisted-by: OpenCode (claude-sonnet-4-6@default) Signed-off-by: Colin Walters <walters@verbum.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation in common/REVIEW.md to include a new section on squashing follow-up fixes and AI-generated suggestions into existing commits for a cleaner history. It also adds a .cursorrules file to the common/ directory. Feedback was provided regarding the .cursorrules file, noting that the path to AGENTS.md should likely be relative (../AGENTS.md) and that the file itself might need to be located at the repository root for proper IDE discovery.
| @@ -0,0 +1 @@ | |||
| AGENTS.md No newline at end of file | |||
There was a problem hiding this comment.
The symlink target AGENTS.md appears to be incorrect for a file located in the common/ subdirectory. Since the target AGENTS.md is at the repository root, the relative path should be ../AGENTS.md. As currently defined, this symlink is broken within this repository. Additionally, for the Cursor IDE to automatically discover these rules, the .cursorrules file typically needs to be located at the repository root rather than in a subdirectory.
../AGENTS.md
1 participant
No description provided.