Use --replacepkgs when installing local builds#2159
Use --replacepkgs when installing local builds#2159jeckersb wants to merge 1 commit intobootc-dev:mainfrom
--replacepkgs when installing local builds#2159Conversation
There was a problem hiding this comment.
Code Review
This pull request adds the --replacepkgs flag to the rpm installation commands in the Dockerfile and the install-rpm-and-setup script to allow replacing existing packages during local builds. A review comment suggests correcting punctuation and grammar in the newly added documentation block in the installation script.
Trying to run tests locally against rawhide was failing, because I have no local modifications and the same package NEVRA already exists in the rhcontainerbot/bootc copr repo which is installed previously. Now if we have the same NEVRA via the local build we'll just re-install the local version as effectively a no-op instead of failing. Signed-off-by: John Eckersberg <jeckersb@redhat.com>
|
This was also implemented in #2146 which is already in the queue, and this one conflicts. |
|
Resurrecting this because it's not totally solved by #2146, I just hit this locally trying to build current Rebasing this one and keeping just the change to |
|
... or not. Apparently the reopen button doesn't actually reopen it, so I'll just make a new PR. |
|
➡️ #2180 |
Trying to run tests locally against rawhide was failing, because I
have no local modifications and the same package NEVRA already exists
in the rhcontainerbot/bootc copr repo which is installed previously.
Now if we have the same NEVRA via the local build we'll just
re-install the local version as effectively a no-op instead of
failing.
Signed-off-by: John Eckersberg jeckersb@redhat.com