Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a helpful hint for users running ephemeral VMs in foreground mode, providing instructions on how to connect via SSH or view the VM output. The review feedback correctly identifies that this hint is redundant when the --console flag is already provided and suggests updating the conditional logic to exclude that case.
When running without -d, print a helpful hint explaining how to connect via SSH or view console output, avoiding confusion about the command appearing to hang. Signed-off-by: gursewak1997 <gursmangat@gmail.com>
cgwalters
approved these changes
May 1, 2026
| // Print helpful hint when running in foreground mode without console | ||
| if !opts.podman.detach && !opts.common.console && std::io::stderr().is_terminal() { | ||
| if let Some(name) = &opts.podman.name { | ||
| eprintln!( |
Collaborator
There was a problem hiding this comment.
Minor nit but I think in general for interacting with the user I would say we should just use println! or possibly indicatif.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running without -d, print a helpful hint explaining how to connect via SSH or view console output, avoiding confusion about the command appearing to hang.
Fixes: #242