cli: Add command to create base disk#254
cli: Add command to create base disk#254Johan-Liebert1 wants to merge 1 commit intobootc-dev:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a create subcommand to the base-disks CLI to facilitate the creation of base disk images. The implementation introduces a CreateBaseDiskOpts struct and integrates image inspection and disk creation logic. Feedback suggests consolidating imports for consistency and making the fields of the new options struct public with descriptive documentation for the CLI help output.
For bootc-dev/bootc#2172 it would be useful for us to create the base disk manually and not delegate it to the `bcvk libvirt run` command Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
Johan-Liebert1
force-pushed
the
base-disk-create-cli
branch
from
22f3c97 to
b83d4ed
Compare
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
This one deserves an integration test too.
| /// Prune unreferenced base disk images | ||
| Prune(PruneOpts), | ||
| /// Create a base disk | ||
| Create(CreateBaseDiskOpts), |
There was a problem hiding this comment.
Maybe call it to-base-disk? Matching bcvk to-disk, but for libvirt and clearly noting that it becomes a base.
There was a problem hiding this comment.
Do you mean as a libvirt subcommand? Like bcvk libvirt to-base-disk or as a top level command bcvk to-base-disk?
There was a problem hiding this comment.
Just as a libvirt subcommand - if it changes libvirt stuff it should be under that right?
2 participants
For bootc-dev/bootc#2172 it would be useful for us to create the base disk manually and not delegate it to the
bcvk libvirt runcommand