to-disk: Fix containers-storage prefix duplication#253
Merged
Johan-Liebert1 merged 1 commit intomainfrom Apr 29, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates generate_bootc_install_command to strip the containers-storage: prefix from the source image name, preventing duplication in the generated command and retry paths. The review feedback suggests that this normalization should be handled more consistently across the entire ToDiskOpts struct, as other methods still use the un-normalized image name which could lead to failures in Podman-related operations.
When bcvk to-disk was called with a containers-storage: prefixed image reference, it would duplicate the prefix resulting in 'containers-storage:containers-storage:...' which caused the bootc install to fail with 'invalid reference format'. Strip the containers-storage: prefix if present before adding it back, ensuring both prefixed and unprefixed inputs normalize to the same format. Signed-off-by: gursewak1997 <gursmangat@gmail.com>
Johan-Liebert1
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When bcvk to-disk was called with a containers-storage: prefixed image reference, it would duplicate the prefix resulting in 'containers-storage:containers-storage:...' which caused the bootc install to fail with 'invalid reference format'.
Strip the containers-storage: prefix if present before adding it back, ensuring both prefixed and unprefixed inputs normalize to the same format.
Fixes: #241