Skip to content

Fix py_thread_callback_SUITE flake on slow CI hosts (#63) #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benoitc merged 6 commits into from
May 3, 2026
Merged

Fix py_thread_callback_SUITE flake on slow CI hosts (#63) #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4a746f1
Fix py_thread_callback_SUITE flake on slow CI hosts (#63)
benoitc May 3, 2026
10cd700
Bound async-callback in-flight via per-pipe atomics counter
benoitc May 3, 2026
39c14d2
Drain async pipe after pipe_broken to stop reader busy-fire
benoitc May 3, 2026
3c56ece
Link async writers to coordinator instead of monitoring
benoitc May 3, 2026
e368ab8
Document the async_futures_mutex no-Python-call invariant
benoitc May 3, 2026
f4e7194
Free poisoned thread workers instead of leaking them
benoitc May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions c_src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,15 @@ option(ENABLE_ASAN "Enable AddressSanitizer" OFF)
option(ENABLE_TSAN "Enable ThreadSanitizer" OFF)
option(ENABLE_UBSAN "Enable UndefinedBehaviorSanitizer" OFF)

# Optional thread-callback I/O tracing. Compiled out by default; turn on
# locally to debug py_thread_callback_SUITE-style flakiness. Logs one
# line per send/receive on stderr.
option(ENABLE_PY_THREAD_CB_TRACE "Trace thread-callback I/O on stderr" OFF)
if(ENABLE_PY_THREAD_CB_TRACE)
message(STATUS "Thread-callback I/O tracing enabled")
add_compile_definitions(PY_THREAD_CB_TRACE=1)
endif()

if(ENABLE_ASAN)
message(STATUS "AddressSanitizer enabled")
add_compile_options(-fsanitize=address -fno-omit-frame-pointer -g -O1)
Expand Down
Loading
Loading