-
-
Notifications
You must be signed in to change notification settings - Fork 3
Export PageData, PageInfo, and param types from the package entry point #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bcomnes
wants to merge
6
commits into
master
Choose a base branch
from
fix/export-public-types
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
98edb50
export PageData, PageInfo, and param types from package entry point
bcomnes 02c04ba
fix: remove TemplateFunctionParams from public API
bcomnes 00a5d63
Add TemplateFunctionParams as an object-shaped typedef
bcomnes cd7d964
Add type smoke test for public entry point exports
bcomnes a25c413
Use TemplateFunctionParams<T> in TemplateAsyncIterator instead of Par…
bcomnes 5148412
fix: add type args and fix @typedef in description to pass tsc
bcomnes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| // @ts-check | ||
| import { test } from 'node:test' | ||
| import assert from 'node:assert' | ||
| import { PageData } from '../../index.js' | ||
|
|
||
| /** | ||
| * Smoke test that all public types are importable from the package entry point. | ||
| * The type imports below are verified by TypeScript at compile time via `npm run test:tsc`. | ||
| * | ||
| * @typedef {import('../../index.js').PageInfo} PageInfo | ||
| * @typedef {import('../../index.js').TemplateInfo} TemplateInfo | ||
| * @typedef {import('../../index.js').LayoutFunctionParams<any>} LayoutFunctionParams | ||
| * @typedef {import('../../index.js').GlobalDataFunctionParams} GlobalDataFunctionParams | ||
| * @typedef {import('../../index.js').PageFunctionParams<any>} PageFunctionParams | ||
| * @typedef {import('../../index.js').TemplateFunctionParams} TemplateFunctionParams | ||
| */ | ||
|
|
||
| test('PageData is importable from the package entry point', () => { | ||
| assert.strictEqual(typeof PageData, 'function', 'PageData is a class') | ||
| }) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.