feat(gazelle): enable pyi attrs by default#3753
Open
amartani wants to merge 1 commit intobazel-contrib:mainfrom
Open
feat(gazelle): enable pyi attrs by default#3753amartani wants to merge 1 commit intobazel-contrib:mainfrom
amartani wants to merge 1 commit intobazel-contrib:mainfrom
Conversation
Default pyi_deps and pyi_srcs generation to true so generated targets preserve type-only dependencies and sibling stub files without extra directives.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the default settings for the Gazelle Python extension, setting both python_generate_pyi_deps and python_generate_pyi_srcs to true by default. The documentation has been expanded with detailed usage examples for these directives, and the CHANGELOG.md and configuration code have been updated to reflect these changes. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default python_generate_pyi_deps and python_generate_pyi_srcs to true so generated targets preserve type-only dependencies and sibling stub files without extra directives. These directives have been available for many versions now, and defaulting to true better matches the intended semantics of current rules_python versions.
Write detailed docs for
python_generate_pyi_depssince that was missing.