Skip to content

Audit fixes#263

Open
roger-bai-coinbase wants to merge 8 commits intomainfrom
audit-fixes
Open

Audit fixes#263
roger-bai-coinbase wants to merge 8 commits intomainfrom
audit-fixes

Conversation

@roger-bai-coinbase
Copy link
Copy Markdown
Contributor

@roger-bai-coinbase roger-bai-coinbase commented Apr 29, 2026 •
edited
Loading

  • Remove unused error in ZKVerifier
  • Update NitroEnclaveVerifier comments on timestamp constraints
  • Change PROOF_THRESHOLD to a constant value of 1
  • Allow nullifications to occur while proof system is paused
  • Delay/prevent resolution if a global verifier is nullified

@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented Apr 29, 2026 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@roger-bai-coinbase roger-bai-coinbase marked this pull request as ready for review April 29, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xenoliss xenoliss xenoliss approved these changes

@leopoldjoy leopoldjoy Awaiting requested review from leopoldjoy

@jackchuma jackchuma Awaiting requested review from jackchuma

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@roger-bai-coinbase @cb-heimdall @xenoliss