Skip to content

fix: use correct resourceType for config bundle in E2E status test#1094

Merged
jariy17 merged 1 commit intoaws:mainfrom
notgitika:fix/e2e-config-bundle-status
May 4, 2026
Merged

fix: use correct resourceType for config bundle in E2E status test#1094
jariy17 merged 1 commit intoaws:mainfrom
notgitika:fix/e2e-config-bundle-status

Conversation

@notgitika
Copy link
Copy Markdown
Contributor

Summary

  • Fix configBundleconfig-bundle in E2E status assertion

The status --json command outputs resourceType: 'config-bundle' (hyphenated) but the test was matching against 'configBundle' (camelCase), causing the status test to always fail with "Config bundle should appear in status: expected undefined to be defined".

Test plan

  • config-bundle-eval-rec.test.ts status test should pass

The status command outputs resourceType as 'config-bundle' (hyphenated)
but the test was checking for 'configBundle' (camelCase).
@notgitika notgitika requested a review from a team May 1, 2026 22:53
@github-actions github-actions Bot added size/xs PR size: XS agentcore-harness-reviewing AgentCore Harness review in progress labels May 1, 2026
@agentcore-cli-automation
Copy link
Copy Markdown

Verified the fix against src/cli/primitives/ConfigBundlePrimitive.ts — the primitive declares readonly kind = 'config-bundle' as const (line 30), and BasePrimitive emits resourceType: this.kind into the status output, so 'config-bundle' is the correct value to match on. The previous 'configBundle' string would never have matched, which explains the always-failing assertion. Looks good to merge.

@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label May 1, 2026
@jariy17 jariy17 merged commit 7fb8a63 into aws:main May 4, 2026
24 checks passed
notgitika added a commit that referenced this pull request May 4, 2026
…1094)

The status command outputs resourceType as 'config-bundle' (hyphenated)
but the test was checking for 'configBundle' (camelCase).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs PR size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants