Skip to content

chore: add debug flag to LR #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tstirrat15 merged 1 commit into from
Apr 28, 2026
Merged

chore: add debug flag to LR #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions authzed/api/v1/core.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,10 +218,7 @@ message AlgebraicSubjectSet {
not_in: [0]
}
];
repeated PermissionRelationshipTree children = 2 [
(validate.rules).repeated.items.message.required = true,
(buf.validate.field).repeated.items.required = true
Copy link
Copy Markdown
Contributor Author

@tstirrat15 tstirrat15 Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is marked as unenforceable by buf lint, so I'm removing it.

];
repeated PermissionRelationshipTree children = 2 [(validate.rules).repeated.items.message.required = true];
}

// DirectSubjectSet is a subject set which is simply a collection of subjects.
Expand Down
11 changes: 2 additions & 9 deletions authzed/api/v1/experimental_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,6 @@ message BulkCheckPermissionRequest {

repeated BulkCheckPermissionRequestItem items = 2 [
(validate.rules).repeated.items.message.required = true,
(buf.validate.field).repeated.items.required = true,
deprecated = true
];
}
Expand Down Expand Up @@ -255,10 +254,7 @@ message BulkCheckPermissionResponse {
(buf.validate.field).required = false
];

repeated BulkCheckPermissionPair pairs = 2 [
(validate.rules).repeated.items.message.required = true,
(buf.validate.field).repeated.items.required = true
];
repeated BulkCheckPermissionPair pairs = 2 [(validate.rules).repeated.items.message.required = true];
}

message BulkCheckPermissionPair {
Expand Down Expand Up @@ -295,10 +291,7 @@ message BulkCheckPermissionResponseItem {
// invocation are executed under this single transaction. If a relationship already
// exists within the datastore, the entire transaction will fail with an error.
message BulkImportRelationshipsRequest {
repeated Relationship relationships = 1 [
(validate.rules).repeated.items.message.required = true,
(buf.validate.field).repeated.items.required = true
];
repeated Relationship relationships = 1 [(validate.rules).repeated.items.message.required = true];
}

// BulkImportRelationshipsResponse is returned on successful completion of the
Expand Down
36 changes: 12 additions & 24 deletions authzed/api/v1/permission_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,15 +379,9 @@ message Precondition {
// the write will be committed. All updates will be applied transactionally,
// and if any preconditions fail, the entire transaction will be reverted.
message WriteRelationshipsRequest {
repeated RelationshipUpdate updates = 1 [
(validate.rules).repeated.items.message.required = true,
(buf.validate.field).repeated.items.required = true
];
repeated RelationshipUpdate updates = 1 [(validate.rules).repeated.items.message.required = true];

repeated Precondition optional_preconditions = 2 [
(validate.rules).repeated.items.message.required = true,
(buf.validate.field).repeated.items.required = true
]; // To be bounded by configuration
repeated Precondition optional_preconditions = 2 [(validate.rules).repeated.items.message.required = true]; // To be bounded by configuration

// optional_transaction_metadata is an optional field that can be used to store metadata about the transaction.
// If specified, this metadata will be supplied in the WatchResponse for the updates associated with this
Expand All @@ -414,10 +408,7 @@ message DeleteRelationshipsRequest {
(buf.validate.field).required = true
];

repeated Precondition optional_preconditions = 2 [
(validate.rules).repeated.items.message.required = true,
(buf.validate.field).repeated.items.required = true
]; // To be bounded by configuration
repeated Precondition optional_preconditions = 2 [(validate.rules).repeated.items.message.required = true]; // To be bounded by configuration

// optional_limit, if non-zero, specifies the limit on the number of relationships to be deleted.
// If there are more matching relationships found to be deleted than the limit specified here,
Expand Down Expand Up @@ -576,10 +567,7 @@ message CheckPermissionResponse {
message CheckBulkPermissionsRequest {
Consistency consistency = 1;

repeated CheckBulkPermissionsRequestItem items = 2 [
(validate.rules).repeated.items.message.required = true,
(buf.validate.field).repeated.items.required = true
];
repeated CheckBulkPermissionsRequestItem items = 2 [(validate.rules).repeated.items.message.required = true];

// with_tracing, if true, indicates that each response should include a debug trace.
// This can be useful for debugging and performance analysis, but adds a small amount
Expand Down Expand Up @@ -621,10 +609,7 @@ message CheckBulkPermissionsResponse {
(buf.validate.field).required = false
];

repeated CheckBulkPermissionsPair pairs = 2 [
(validate.rules).repeated.items.message.required = true,
(buf.validate.field).repeated.items.required = true
];
repeated CheckBulkPermissionsPair pairs = 2 [(validate.rules).repeated.items.message.required = true];
}

message CheckBulkPermissionsPair {
Expand Down Expand Up @@ -751,6 +736,12 @@ message LookupResourcesRequest {
// optional_cursor, if specified, indicates the cursor after which results should resume being returned.
// The cursor can be found on the LookupResourcesResponse object.
Cursor optional_cursor = 7;
//
// with_debug, if true, indicates that the response should return debug information
// if present and available. For now, ONLY enables debugging of maximum recursion depth
// errors, with additional context being returned in error details, but this may be
// extended in the future.
bool with_debug = 8;
}

// LookupPermissionship represents whether a Lookup response was partially evaluated or not
Expand Down Expand Up @@ -966,10 +957,7 @@ message ResolvedSubject {
// invocation are executed under this single transaction. If a relationship already
// exists within the datastore, the entire transaction will fail with an error.
message ImportBulkRelationshipsRequest {
repeated Relationship relationships = 1 [
(validate.rules).repeated.items.message.required = true,
(buf.validate.field).repeated.items.required = true
];
repeated Relationship relationships = 1 [(validate.rules).repeated.items.message.required = true];
}

// ImportBulkRelationshipsResponse is returned on successful completion of the
Expand Down
Loading