Skip to content

chore: make API changes compatible with Selenium 4.42.0-SNAPSHOT#2390

Merged
valfirst merged 5 commits intoappium:masterfrom
asolntsev:update/selenium-4.42.0
Apr 19, 2026
Merged

chore: make API changes compatible with Selenium 4.42.0-SNAPSHOT#2390
valfirst merged 5 commits intoappium:masterfrom
asolntsev:update/selenium-4.42.0

Conversation

@asolntsev
Copy link
Copy Markdown
Contributor

@asolntsev asolntsev commented Mar 5, 2026

Change list

Unfortunately, signature of this public method have been changed in Selenium 4.42.0-SNAPSHOT:

  • org.openqa.selenium.support.ui.FluentWait#until

When Selenium 4.24.0 gets release, we will need to merge this PR to fix the compilation error.

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Breaking changes

FlluentWait

See PR https://github.com/SeleniumHQ/selenium/pull/17149/changes (fixes issue SeleniumHQ/selenium#17122 - compilation error in Kotlin projects because of nullable/nonnullable types).

Before:

  @Override
  public <V> V until(Function<? super T, @Nullable V> isTrue) { ... }

After:

  @Override
  public <V extends @Nullable Object> @NonNull V until(Function<? super T, ? extends V> isTrue) { ... }

Comment thread src/main/java/io/appium/java_client/AppiumExecutionMethod.java Outdated
@mykola-mokhnach
Copy link
Copy Markdown
Contributor

Could you please prepare a detailed list of breaking changes, so we could add them into the release notes document?

Unfortunately, these two public methods have been changed in Selenium 4.24.0-SNAPSHOT:

* org.openqa.selenium.remote.ExecuteMethod#execute
* org.openqa.selenium.support.ui.FluentWait#until
I've restored the original signature of `ExecuteMethod` in Selenium 4.24.0-SNAPSHOT (will come with next nightly build).
@asolntsev asolntsev force-pushed the update/selenium-4.42.0 branch from 8aae888 to 8b63a3a Compare March 6, 2026 09:34
@asolntsev asolntsev changed the title make API changes compatible with Selenium 4.24.0-SNAPSHOT chore: make API changes compatible with Selenium 4.24.0-SNAPSHOT Mar 6, 2026
@mykola-mokhnach
Copy link
Copy Markdown
Contributor

I assume the snapshot version should be 4.42.0 rather than 4.24.0

@asolntsev asolntsev changed the title chore: make API changes compatible with Selenium 4.24.0-SNAPSHOT chore: make API changes compatible with Selenium 4.42.0-SNAPSHOT Mar 11, 2026
@asolntsev
Copy link
Copy Markdown
Contributor Author

asolntsev commented Mar 11, 2026

I assume the snapshot version should be 4.42.0 rather than 4.24.0

Sure, fixed to 4.42.0-SNAPSHOT.

asolntsev and others added 3 commits March 11, 2026 09:24
In this context, "changing modules" means "SNAPSHOT"s. So Gradle will be force to reload only snapshots, and it doesn't affect normal work with stable versions.
@asolntsev asolntsev marked this pull request as ready for review April 16, 2026 17:34
@valfirst valfirst merged commit 6b7597f into appium:master Apr 19, 2026
9 of 12 checks passed
@asolntsev asolntsev deleted the update/selenium-4.42.0 branch April 19, 2026 17:42
@KazuCocoa KazuCocoa added the size:S contribution size: S label May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S contribution size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants