Skip to content

test: update test_request_deduplication_edge_cases#884

Open
Mantisus wants to merge 1 commit intoapify:masterfrom
Mantisus:update-test_request_deduplication_edge_cases
Open

test: update test_request_deduplication_edge_cases#884
Mantisus wants to merge 1 commit intoapify:masterfrom
Mantisus:update-test_request_deduplication_edge_cases

Conversation

@Mantisus
Copy link
Copy Markdown
Collaborator

@Mantisus Mantisus commented May 3, 2026

Closes: #786

@Mantisus Mantisus requested a review from vdusek May 3, 2026 23:55
@Mantisus Mantisus self-assigned this May 3, 2026
Copy link
Copy Markdown
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but I would rather see the root cause investigation and actually trace where the empty processedRequests comes from, rather than retry in test workaround 🙂.

@janbuchar
Copy link
Copy Markdown
Contributor

Thanks, but I would rather see the root cause investigation and actually trace where the empty processedRequests comes from, rather than retry in test workaround 🙂.

It's a frustrating answer, but due to the nature of the Request Queue, this sometimes just... happens. It is an established fact that the API leaks implementation details. Maybe we should make sure we plug that leak at the SDK level at least, though.

@vdusek
Copy link
Copy Markdown
Contributor

vdusek commented May 4, 2026

It's a frustrating answer, but due to the nature of the Request Queue, this sometimes just... happens. It is an established fact that the API leaks implementation details. Maybe we should make sure we plug that leak at the SDK level at least, though.

Yeah, in that case, we should try to address this in the ApifyStorageClient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test test_request_deduplication_edge_cases[shared] is flaky

4 participants