Skip to content

ci(release): add documentation versioning to release workflow#1120

Merged
l2ysho merged 5 commits intomasterfrom
add-version-workflow
May 5, 2026
Merged

ci(release): add documentation versioning to release workflow#1120
l2ysho merged 5 commits intomasterfrom
add-version-workflow

Conversation

@l2ysho
Copy link
Copy Markdown
Contributor

@l2ysho l2ysho commented May 5, 2026

Automatically snapshots current documentation for each major.minor release to provide historical versions.

Automatically snapshots current documentation for each major.minor release to provide historical versions.
@l2ysho l2ysho requested review from DaveHanns and patrikbraborec May 5, 2026 15:57
@l2ysho l2ysho requested a review from vladfrangu as a code owner May 5, 2026 15:57
@github-actions github-actions Bot added this to the 140th sprint - Tooling team milestone May 5, 2026
@github-actions github-actions Bot added the t-tooling Issues with this label are in the ownership of the tooling team. label May 5, 2026
@l2ysho
Copy link
Copy Markdown
Contributor Author

l2ysho commented May 5, 2026

dispatch added so I can test it without release

@l2ysho l2ysho added t-dx Issues owned by the DX team. adhoc Ad-hoc unplanned task added during the sprint. labels May 5, 2026
Copy link
Copy Markdown
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick thing to check

node-version: 24

- name: Install pnpm and dependencies
uses: apify/workflows/pnpm-install@main
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to also have a run step that runs pnpm install in website (they are not workspaces but maybe they should be?)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no opinion over workspace, I will create an issue and we can discuss there. Also pnpm install added.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other pnpm PRs added website to the workspace iirc, lets do it here as well. two places for inspiration are the JS client and SDK, both already migrated

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok then :]

Ensure website dependencies are available for snapshotting documentation.
@l2ysho l2ysho requested review from B4nan and vladfrangu May 5, 2026 19:12
Copy link
Copy Markdown
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (but only had a brief look)

@l2ysho
Copy link
Copy Markdown
Contributor Author

l2ysho commented May 5, 2026

lgtm (but only had a brief look)

I will do one with claude and wait for @vladfrangu

Copy link
Copy Markdown
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to delete the website pnpm lock file

@l2ysho l2ysho merged commit d3bc9f2 into master May 5, 2026
23 checks passed
@l2ysho l2ysho deleted the add-version-workflow branch May 5, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-dx Issues owned by the DX team. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants