test(frontend): add unit tests for DatasetFileSelectorComponent#5576
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5576 +/- ##
============================================
+ Coverage 52.17% 52.20% +0.02%
Complexity 2482 2482
============================================
Files 1068 1068
Lines 41311 41311
Branches 4439 4439
============================================
+ Hits 21556 21565 +9
+ Misses 18490 18480 -10
- Partials 1265 1266 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Adds a unit test spec for DatasetFileSelectorComponent, which previously had no *.spec.ts. The component is a Formly field type whose onClickOpenFileSelectionModal() opens a dataset-selection modal and writes the chosen path back into the form control when the modal closes with a value.
Any related issues, documentation, discussions?
Closes #5471
How was this PR tested?
New unit tests added in dataset-file-selector.component.spec.ts, run via
ng test(Vitest). They cover:All 5 tests pass; eslint and prettier checks are clean.
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code