benchmarks/mtd: use uniform output style for numbers#3535
Open
sumpfralle wants to merge 1 commit into
Open
Conversation
One of the four values emitted by this interactive tools uses the hexadecimal presentation. The other values are decimal numbers. Now the confusion is avoided: all numbers use the decimal representation. In addition the suffix "size" is added to the "Erase block" label in order to clarify its meaning. Signed-off-by: Lars Kruse <devel@sumpfralle.de>
cederom
approved these changes
Jun 9, 2026
cederom
left a comment
cederom
left a comment
Contributor
There was a problem hiding this comment.
Thank you @sumpfralle :-) Please to remember to attach build and runtime logs after change :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously the output of the
mtdbenchmark tool looked like this:The third line sneakily deviated from the format of the other lines:
1000is a hexadecimal number.There is no good reason for using the hexadecimal representation for this specific value.
Impact
The change influences only the human readable output of the interactive
mtdbenchmark tool.Testing
I tried the
mtdtool before and after on myrp2040board.The numbers looked much better afterwards.