NIFI-15853 - Support fetchable allowable values in the connector wizard. added searchable select component.#11159
Open
rfellows wants to merge 3 commits intoapache:mainfrom
Open
NIFI-15853 - Support fetchable allowable values in the connector wizard. added searchable select component.#11159rfellows wants to merge 3 commits intoapache:mainfrom
rfellows wants to merge 3 commits intoapache:mainfrom
Conversation
Contributor
|
Reviewing... |
…rd. added searchable select component.
Replace text-md (no-op in v3, undefined in v4) with text-base and flex-shrink-0 (renamed in v4) with shrink-0 in the searchable-select template. Update the spec selector to match.
…hable-select Add a shared EllipsisTooltipDirective that mounts a MatTooltip on the host and only enables it when the rendered text is actually clipped (horizontal or vertical overflow). Replace the always-on native [title] attributes in the searchable-select option labels and footer messages so the tooltip is themed, positioned consistently, and only appears when needed. Observers attach lazily on hover/focus to keep large option lists cheap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-15853
This pull request fixes connector wizard properties whose allowable values must be loaded from the backend (
allowableValuesFetchable === truewith no staticallowableValues). Previously those properties were rendered as a plain text control and never triggered the allowable-values request, so users could not pick from server-provided options.The fix introduces a reusable SearchableSelect component (Material-based,
ControlValueAccessor) and routes both static and dynamic allowable values through it. ConnectorPropertyInput now emitsrequestAllowableValuesexactly once per fetchable control when the step loads (guarded byhasFetchedDynamicValues), and resets that guard when the bound descriptor'sproperty.namechanges so a rebound descriptor can refetch. Loading, error, and empty responses are handled with fallbacks so the field stays usable (text input or textarea as appropriate).STRING_LIST properties now render as a multi-select when allowable values exist (static or dynamic), and as a comma-separated textarea when they do not — replacing the previous plain text input for that type.
Scope
nifi-frontend/src/main/frontend(~4800 insertions, ~77 deletions on squashed commit75068da3e3).New / updated shared UI
SearchableSelect(libs/shared/src/components/searchable-select/): filterable overlay select with optional multi-select, sticky search with clear, optional async search and virtual scrolling, optional grouped options, loading/error/empty states, full keyboard navigation, and accessibility (role="combobox",aria-*). Spec file adds broad coverage (107 tests covering single/multi select, filter, keyboard navigation, focus management, virtual scrolling, async search, grouping, value-change deduplication, and disabled states).MultiSelectOption: extendsMatOptionfor options inside the overlay; theming (min-height, padding, hover, selected, keyboard focus) is scoped under.multi-select-optionso othermat-selectusages are unaffected.ConnectorPropertyInput: template moved toconnector-property-input.component.html; helpers for input kind and dynamic state (shouldUseSelect,shouldUseTextInput,shouldUseTextarea,isMultiSelect,isDynamicValuesFetchEmpty,isDynamicValuesFetchFailed); textarea branch aligned with text input for validation errors (required,pattern,verificationError,assetContentMissingwhere applicable).libs/shared/src/components/index.tsandlibs/shared/src/types/index.tsupdated for new components/types.Visible UX (intentional)
allowableValuesdropdowns now use searchable-select instead of mat-select (search filter + clear control) so static and dynamic flows share one widget.Out of scope / follow-ups
Screenshots
Fetched allowable values from the KafkaToS3 connector for topic names

Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-15853NIFI-15853VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-check(Frontend-only change under
nifi-frontend; full rootcontrib-checkshould still be run per project norms before merge.)Licensing
LICENSEandNOTICEfilesDocumentation