Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

backport installation guide changes to previous versions by redirecting#18658

Draft
ys2843 wants to merge 2 commits intoapache:masterfrom
ys2843:redirect-installation-guide-to-master
Draft

backport installation guide changes to previous versions by redirecting#18658
ys2843 wants to merge 2 commits intoapache:masterfrom
ys2843:redirect-installation-guide-to-master

Conversation

@ys2843
Copy link
Copy Markdown
Contributor

@ys2843 ys2843 commented Jul 3, 2020

Description

Redirect install page in previous versions to master due to Apache license issues. According to Google Analytics data, 96% of installation guide traffic are from master, the sum of all the other versions (0.11.0 ~ 1.6) only account for 4%. Considering previous version website are all static artifact which are not applicable to make changes. After discussion, we will redirect users to master installation page to avoid showing different versions of docs.

/versions/1.6/get_started
/versions/1.5.1/install/index.html
/versions/1.4.1/install/index.html
/versions/1.3.1/install/index.html
/versions/1.2.1/install/index.html
/versions/1.1.0/install/index.html
/versions/1.0.0/install/index.html
/versions/0.12.1/install/index.html
/versions/0.11.0/get_started/install.html

=> 

/get_started?version=v${version}

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:

Changes

  • Add rewrite rules to redirect previous versions install page

Comments

@ys2843 ys2843 requested review from aaronmarkham and szha as code owners July 3, 2020 00:47
@mxnet-bot
Copy link
Copy Markdown

Hey @ys2843 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [clang, edge, centos-gpu, miscellaneous, unix-cpu, centos-cpu, sanity, windows-cpu, unix-gpu, windows-gpu, website]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@ys2843
Copy link
Copy Markdown
Contributor Author

ys2843 commented Jul 3, 2020

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link
Copy Markdown

Jenkins CI successfully triggered : [unix-cpu]

@ys2843
Copy link
Copy Markdown
Contributor Author

ys2843 commented Jul 3, 2020

@mxnet-label-bot update [Website]

@mxnet-bot
Copy link
Copy Markdown

Jenkins CI successfully triggered : [unix-cpu]

@ys2843 ys2843 force-pushed the redirect-installation-guide-to-master branch from 49bf395 to 3d8c7b3 Compare July 4, 2020 18:32
@mxnet-bot
Copy link
Copy Markdown

Jenkins CI successfully triggered : [website]

@mxnet-bot
Copy link
Copy Markdown

Jenkins CI successfully triggered : [unix-cpu]

@lanking520 lanking520 added the pr-awaiting-review PR is waiting for code review label Jul 5, 2020
@leezu
Copy link
Copy Markdown
Contributor

leezu commented Jul 5, 2020

Thank you @ys2843. For the forwarding, can you add the respective version number argument in the URL (if possible)? For example, when accessing the install page on 1.2.1, I get forwarded to the get_started page, but the 1.6 version is selected by default. By passing the /get_started?version=v1.2.1 url parameter, the correct version would be specified.

@ys2843 ys2843 closed this Jul 6, 2020
@ys2843 ys2843 reopened this Jul 6, 2020
@ys2843
Copy link
Copy Markdown
Contributor Author

ys2843 commented Jul 6, 2020

Thank you @ys2843. For the forwarding, can you add the respective version number argument in the URL (if possible)? For example, when accessing the install page on 1.2.1, I get forwarded to the get_started page, but the 1.6 version is selected by default. By passing the /get_started?version=v1.2.1 url parameter, the correct version would be specified.

Brilliant idea, done.
Just found a version conflict on v1.5, on general version dropdown it is 1.5.0, but in installation guide it is 1.5.1.

@lanking520 lanking520 removed the pr-awaiting-review PR is waiting for code review label Jul 8, 2020
@ys2843 ys2843 marked this pull request as draft July 10, 2020 18:34
@ys2843 ys2843 force-pushed the redirect-installation-guide-to-master branch from 61b5160 to bb24522 Compare July 19, 2020 23:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants