Skip to content

API: Remove unnecessary EOFException in FileRange constructor.#15973

Merged
huaxingao merged 2 commits into
apache:mainfrom
mukund-thakur:remove_eof
May 12, 2026
Merged

API: Remove unnecessary EOFException in FileRange constructor.#15973
huaxingao merged 2 commits into
apache:mainfrom
mukund-thakur:remove_eof

Conversation

@mukund-thakur
Copy link
Copy Markdown
Contributor

@mukund-thakur mukund-thakur commented Apr 14, 2026

Fixes #15972

Testing

Re ran the iceberg-api and iceberg-parquet unit tests.

Comment thread api/src/main/java/org/apache/iceberg/io/FileRange.java
Comment thread parquet/src/main/java/org/apache/iceberg/parquet/ParquetIO.java Outdated
Comment thread parquet/src/main/java/org/apache/iceberg/parquet/ParquetIO.java
Comment thread api/src/main/java/org/apache/iceberg/io/FileRange.java
@mukund-thakur
Copy link
Copy Markdown
Contributor Author

Hi @huaxingao . Could you please take a look at this. It is on top of #15926 Thanks

@huaxingao
Copy link
Copy Markdown
Contributor

@mukund-thakur Could you remove the new Javadoc on convertRanges? @ebyhr asked the same and the thread got resolved without removing it.

Copy link
Copy Markdown
Contributor

@huaxingao huaxingao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huaxingao huaxingao merged commit 947a7b7 into apache:main May 12, 2026
37 checks passed
@huaxingao
Copy link
Copy Markdown
Contributor

Thanks @mukund-thakur for the PR! Thanks @ebyhr for the review!

@mukund-thakur
Copy link
Copy Markdown
Contributor Author

Thank you @huaxingao and @ebyhr !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API: Remove unnecessary EOFException FileRange constructor.

4 participants