[c++] Add nullability support for data type in c++#525
Merged
fresh-borzoni merged 7 commits intoapache:mainfrom May 8, 2026
Merged
[c++] Add nullability support for data type in c++#525fresh-borzoni merged 7 commits intoapache:mainfrom
fresh-borzoni merged 7 commits intoapache:mainfrom
Conversation
Contributor
leekeiabstraction
left a comment
leekeiabstraction
left a comment
There was a problem hiding this comment.
TY for the PR, left a question.
Contributor
Author
|
thanks for the question. i replied, let me know if further question @leekeiabstraction if find time, would be great to give a look @fresh-borzoni @leekeiabstraction 🙏 |
Member
fresh-borzoni
left a comment
fresh-borzoni
left a comment
There was a problem hiding this comment.
@charlesdong1991 Ty for the PR, overall LGTM
Left some comments, PTAL
Contributor
Author
|
thanks for great suggestion @fresh-borzoni i split the array from scaler, PTAL! |
fresh-borzoni
approved these changes
May 6, 2026
Member
fresh-borzoni
left a comment
fresh-borzoni
left a comment
There was a problem hiding this comment.
@charlesdong1991 Ty, LGTM 👍
Member
|
@leekeiabstraction Do you have any further comments on this PR? |
Member
|
@charlesdong1991 Ty, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Preserve nullability when constructing Fluss schemas through the C++ binding. Previously, the C++
DataTypeclass had no nullable flag, so all types defaulted to nullable regardless of what the user specified.Linked issue: close #510
Tests
All tests have passed locally
Documentation
Docs are updated accordingly.