Skip to content

FINERACT-405: Centralize mobile number validation regex#5964

Draft
anubhavio wants to merge 1 commit into
apache:developfrom
anubhavio:FINERACT-405-phone-validation-centralization
Draft

FINERACT-405: Centralize mobile number validation regex#5964
anubhavio wants to merge 1 commit into
apache:developfrom
anubhavio:FINERACT-405-phone-validation-centralization

Conversation

@anubhavio

@anubhavio anubhavio commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Description

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

FINERACT-405: Add missing ASF license header
@anubhavio anubhavio force-pushed the FINERACT-405-phone-validation-centralization branch from abdd8a2 to 3614282 Compare June 9, 2026 13:06

public class PhoneNumberConstants {

public static final String MOBILE_NUMBER_REGEX =

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be configurable in a property, not fixed.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IOhacker Thanks for the feedback. I investigated the existing validation and configuration patterns in Fineract. To make the regex configurable, I plan to move it into FineractProperties and replace the Staff @pattern validation with a custom validator backed by a shared PhoneNumberValidationService, so both Client and Staff validations use the same configurable rule.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anubhavio that is the best approach to use the same configurable rule.

@anubhavio anubhavio marked this pull request as draft June 11, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants