branch-4.1: [fix](be) Fix ANN query vector extraction to handle all constant expression types #62637#62926
Open
github-actions[bot] wants to merge 1 commit intobranch-4.1from
Open
branch-4.1: [fix](be) Fix ANN query vector extraction to handle all constant expression types #62637#62926github-actions[bot] wants to merge 1 commit intobranch-4.1from
github-actions[bot] wants to merge 1 commit intobranch-4.1from
Conversation
…ession types (#62637) ## Proposed changes Fix `extract_query_vector` in `ann_topn_runtime.cpp` to handle all constant expression types instead of only `VArrayLiteral` and `VCastExpr`. ### What problem does this PR solve? Issue Number: close #xxx Problem Summary: The `extract_query_vector` function previously checked whether the query vector argument was specifically a `VArrayLiteral` or `VCastExpr` via `dynamic_pointer_cast`. When FE produced other constant expression forms (e.g., after expression rewrites), ANN index queries would fail with `InvalidArgument: Constant must be ArrayLiteral or CAST to array`. The fix removes the rigid type check and instead: 1. Calls `get_const_col()` to materialize the constant expression 2. Unwraps `ColumnConst` via `check_and_get_column<ColumnConst>` to get the underlying data column 3. Validates the resulting column shape (Nullable → Array → Float32) This approach works for any constant expression that materializes to an array column, regardless of the expression node type. ### Release note Fix ANN vector index query failure when the query vector expression is not a direct array literal or CAST expression. ### Check List (For Author) - Test: Regression test - Behavior changed: No - Does this need documentation: No
Contributor
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #62637