Clearly gate sliding SUM(DISTINCT) type support#22866
Open
kumarUjjawal wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
sqllogictest
Contributor
Author
|
@kosiew Should we later on add support for the missing types? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
SUM(DISTINCT)type support #22820.Rationale for this change
Sliding
SUM(DISTINCT)only supportsInt64, but it was routed through the widerSUMtype dispatch path. This made unsupported types fail with a less clear accumulator error.What changes are included in this PR?
This PR adds an explicit
Int64gate for slidingSUM(DISTINCT).Unsupported types now return a clear feature error that names the operation and type. The existing
Int64path is unchanged.Are these changes tested?
Yes
Are there any user-facing changes?
No public API change