Rich t kid/multi dictionary benchmarks#22859
Open
Rich-T-kid wants to merge 2 commits into
Open
Conversation
Rich-T-kid
commented
Jun 9, 2026
Rich-T-kid
left a comment
Rich-T-kid
left a comment
Contributor
Author
There was a problem hiding this comment.
going to take another review tomorrow before pinging a reviewer to take a look!
| Arc::new(DictionaryArray::<UInt64Type>::try_new(key_array, values).unwrap()) | ||
| } | ||
|
|
||
| fn make_batch( |
Contributor
Author
There was a problem hiding this comment.
I think we should add a value type as a parameter here. strings are currently covered, in the future it may make sense for other types to also be covered. I left that out for this PR but I can introduce it if needed.
| /// each column's distinct count is sampled from [target*0.95, target*1.05]. | ||
| const CARDINALITY_RANGE: usize = 10; | ||
|
|
||
| fn schema_for_cols(n_cols: usize) -> SchemaRef { |
Contributor
Author
There was a problem hiding this comment.
if/when we introduce other value data types, this function needs to change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Works towards closing #21878
Rationale for this change
There is currently no benchmarks that cover
GroupValueRow()when dictionary arrays are passed in. #22004 adds benchmarks for the single single column case. This PR adds benchmarks for the multi column caseWhat changes are included in this PR?
Adds a new Criterion harness for GroupValues over multi-column Dictionary<UInt64, Utf8> GROUP BY workloads, covering 4 and 8 group-by columns across batch sizes of 8 KiB and 64 KiB rows. It tests four realistic cardinalities (20, 100, 500, 1 000 distinct values) with per-column variance introduced by sampling each column's distinct count from a ±5% window around the target, so columns within the same batch have slightly different cardinalities. Two benchmark variants are included — repeated intern+emit and a partial-emit pattern that spills half the accumulated groups after each intern — to stress both the steady-state and incremental-flush paths of the group values implementation.
Are these changes tested?
n/a
Are there any user-facing changes?
No