Add sort tpch SQL benchmark#22814
Open
Omega359 wants to merge 4 commits into
Open
Conversation
adriangb
approved these changes
Jun 9, 2026
| SELECT l_linenumber, l_suppkey, l_orderkey | ||
| FROM lineitem | ||
| ORDER BY l_linenumber, l_suppkey, l_orderkey | ||
| ${LIMIT:-false|LIMIT 100| } |
Contributor
There was a problem hiding this comment.
Do we need to document these env vars?
Contributor
Author
There was a problem hiding this comment.
I think they're documented in the sql_benchmarks/README.md but I'd have to check
Contributor
There was a problem hiding this comment.
There are some that are shared (LIMIT makes sense as shared) and some that are per benchmark. I have seen them documented, but I'm not sure if we're documenting which global ones apply to which benchmarks (i.e. what options each bench supports). As in: without looking at the actual benchmark code I wouldn't know that this benchmark accepts / respects LIMIT.
Contributor
Author
There was a problem hiding this comment.
This likely should be addressed as part of #21935
Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #21706
Rationale for this change
Continue work on sql benchmark migration.
What changes are included in this PR?
sort_tpch sql benchmark
Are these changes tested?
Yes
BENCH_NAME=sort_tpch cargo bench --bench sqlBENCH_NAME=sort_tpch BENCH_SIZE=10 cargo bench --bench sqlBENCH_NAME=sort_tpch LIMIT=true cargo bench --bench sqlBENCH_NAME=sort_tpch BENCH_SIZE=10 LIMIT=true cargo bench --bench sqlAre there any user-facing changes?
No