Skip to content

Adding Use of arrow's has_true() / has_false()#21806

Open
raushanprabhakar1 wants to merge 1 commit intoapache:mainfrom
raushanprabhakar1:feat/21784-has-true-has-false
Open

Adding Use of arrow's has_true() / has_false()#21806
raushanprabhakar1 wants to merge 1 commit intoapache:mainfrom
raushanprabhakar1:feat/21784-has-true-has-false

Conversation

@raushanprabhakar1
Copy link
Copy Markdown

Which issue does this PR close?

Closes #21784

Rationale for this change

Apache Arrow added BooleanArray::has_true() and has_false() so callers can answer “any true/false?” without a full bit count. That can short-circuit and avoid unnecessary work compared to patterns like true_count() == 0 or true_count() > 0.

This PR applies those APIs across DataFusion where the logic is purely existential (or equivalent via null-safe “all true” / “no true” checks), matching the audit suggested in the issue.

What changes are included in this PR?

  • Replace hot-path checks that only needed existence or emptiness with has_true() / has_false() (and null_count() where needed), including:
    • Nested/array helpers (array_has, list replace), Spark array_contains null-semantics fast path
    • Physical expressions: evaluate_selection, binary AND/OR short-circuit, CASE/IN list loops
    • scatter fast paths
    • Top-K filter handling, sort-merge join filter, nested-loop join bitmap checks
    • Parquet column stats (metadata.rs, has_any_exact_match)
  • Keep true_count() / false_count() where an actual count is required (row counts, metrics, selectivity, to_array(n), etc.)
  • Import arrow::array::Array where null_count() is used on BooleanArray in trait-heavy paths

Are these changes tested?

Existing tests cover this behavior; the edits are semantics-preserving refactors (same conditions, cheaper primitives). No new tests were added.

Are there any user-facing changes?

No. Behavior should be unchanged; this is an internal performance/clarity improvement.

@github-actions github-actions Bot added physical-expr Changes to the physical-expr crates functions Changes to functions implementation datasource Changes to the datasource crate physical-plan Changes to the physical-plan crate spark labels Apr 23, 2026
@adriangb
Copy link
Copy Markdown
Contributor

run benchmarks

@adriangbot
Copy link
Copy Markdown

Benchmark for this request failed.

Last 20 lines of output:

Click to expand
Cloning into '/workspace/datafusion-branch'...
error: RPC failed; HTTP 500 curl 22 The requested URL returned error: 500
fatal: expected 'acknowledgments'

File an issue against this benchmark runner

@adriangbot
Copy link
Copy Markdown

🤖 Benchmark running (GKE) | trigger
Instance: c4a-highmem-16 (12 vCPU / 65 GiB) | Linux bench-c4305985687-1779-7645x 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux

CPU Details (lscpu)
Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected

Comparing feat/21784-has-true-has-false (ca7e0a8) to 067ba4b (merge-base) diff using: clickbench_partitioned
Results will be posted here when complete


File an issue against this benchmark runner

@adriangbot
Copy link
Copy Markdown

🤖 Benchmark running (GKE) | trigger
Instance: c4a-highmem-16 (12 vCPU / 65 GiB) | Linux bench-c4305985687-1781-wplz4 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux

CPU Details (lscpu)
Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected

Comparing feat/21784-has-true-has-false (ca7e0a8) to 067ba4b (merge-base) diff using: tpch
Results will be posted here when complete


File an issue against this benchmark runner

@adriangbot
Copy link
Copy Markdown

🤖 Benchmark completed (GKE) | trigger

Instance: c4a-highmem-16 (12 vCPU / 65 GiB)

CPU Details (lscpu)
Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected
Details

Comparing HEAD and feat_21784-has-true-has-false
--------------------
Benchmark tpch_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Query     ┃                           HEAD ┃  feat_21784-has-true-has-false ┃    Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ QQuery 1  │ 41.58 / 42.39 ±0.99 / 44.33 ms │ 41.34 / 42.33 ±1.19 / 44.58 ms │ no change │
│ QQuery 2  │ 21.67 / 22.31 ±0.44 / 23.03 ms │ 21.73 / 22.58 ±0.67 / 23.47 ms │ no change │
│ QQuery 3  │ 40.69 / 43.46 ±1.73 / 45.51 ms │ 40.06 / 42.41 ±1.42 / 44.50 ms │ no change │
│ QQuery 4  │ 18.96 / 19.59 ±0.89 / 21.31 ms │ 18.72 / 18.89 ±0.13 / 19.04 ms │ no change │
│ QQuery 5  │ 50.02 / 51.83 ±1.19 / 53.29 ms │ 49.47 / 50.87 ±1.92 / 54.67 ms │ no change │
│ QQuery 6  │ 17.84 / 18.46 ±0.38 / 18.87 ms │ 17.97 / 18.01 ±0.06 / 18.13 ms │ no change │
│ QQuery 7  │ 56.94 / 58.58 ±0.94 / 59.70 ms │ 55.68 / 58.34 ±2.12 / 61.88 ms │ no change │
│ QQuery 8  │ 49.70 / 50.31 ±0.39 / 50.85 ms │ 48.88 / 49.51 ±0.44 / 50.02 ms │ no change │
│ QQuery 9  │ 56.34 / 57.33 ±0.81 / 58.54 ms │ 54.26 / 55.47 ±0.74 / 56.28 ms │ no change │
│ QQuery 10 │ 67.41 / 69.56 ±2.14 / 73.25 ms │ 66.87 / 68.61 ±1.26 / 70.26 ms │ no change │
│ QQuery 11 │ 14.65 / 15.24 ±0.66 / 16.47 ms │ 14.76 / 15.33 ±0.72 / 16.74 ms │ no change │
│ QQuery 12 │ 28.35 / 28.78 ±0.55 / 29.83 ms │ 27.78 / 29.13 ±1.63 / 32.24 ms │ no change │
│ QQuery 13 │ 37.33 / 39.30 ±1.16 / 40.67 ms │ 38.31 / 39.10 ±0.48 / 39.53 ms │ no change │
│ QQuery 14 │ 28.44 / 28.82 ±0.28 / 29.26 ms │ 28.46 / 28.72 ±0.23 / 29.13 ms │ no change │
│ QQuery 15 │ 34.47 / 35.20 ±0.49 / 35.90 ms │ 34.45 / 35.32 ±0.81 / 36.59 ms │ no change │
│ QQuery 16 │ 15.70 / 15.82 ±0.09 / 15.96 ms │ 15.50 / 15.60 ±0.09 / 15.75 ms │ no change │
│ QQuery 17 │ 81.81 / 83.61 ±1.35 / 85.23 ms │ 80.93 / 81.93 ±0.98 / 83.49 ms │ no change │
│ QQuery 18 │ 77.99 / 80.06 ±1.16 / 81.47 ms │ 76.80 / 77.97 ±0.89 / 79.06 ms │ no change │
│ QQuery 19 │ 38.66 / 39.53 ±1.31 / 42.14 ms │ 37.92 / 38.50 ±0.35 / 38.93 ms │ no change │
│ QQuery 20 │ 40.65 / 41.51 ±0.99 / 43.43 ms │ 40.11 / 41.35 ±2.20 / 45.74 ms │ no change │
│ QQuery 21 │ 66.22 / 67.00 ±0.80 / 68.38 ms │ 64.30 / 65.21 ±0.73 / 66.34 ms │ no change │
│ QQuery 22 │ 17.66 / 18.37 ±0.88 / 20.11 ms │ 17.42 / 18.00 ±0.47 / 18.58 ms │ no change │
└───────────┴────────────────────────────────┴────────────────────────────────┴───────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━┓
┃ Benchmark Summary                            ┃          ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━┩
│ Total Time (HEAD)                            │ 927.09ms │
│ Total Time (feat_21784-has-true-has-false)   │ 913.17ms │
│ Average Time (HEAD)                          │  42.14ms │
│ Average Time (feat_21784-has-true-has-false) │  41.51ms │
│ Queries Faster                               │        0 │
│ Queries Slower                               │        0 │
│ Queries with No Change                       │       22 │
│ Queries with Failure                         │        0 │
└──────────────────────────────────────────────┴──────────┘

Resource Usage

tpch — base (merge-base)

Metric Value
Wall time 5.0s
Peak memory 5.4 GiB
Avg memory 4.8 GiB
CPU user 35.1s
CPU sys 2.6s
Peak spill 0 B

tpch — branch

Metric Value
Wall time 5.0s
Peak memory 5.5 GiB
Avg memory 4.8 GiB
CPU user 34.7s
CPU sys 2.5s
Peak spill 0 B

File an issue against this benchmark runner

@adriangbot
Copy link
Copy Markdown

🤖 Benchmark completed (GKE) | trigger

Instance: c4a-highmem-16 (12 vCPU / 65 GiB)

CPU Details (lscpu)
Architecture:                            aarch64
CPU op-mode(s):                          64-bit
Byte Order:                              Little Endian
CPU(s):                                  16
On-line CPU(s) list:                     0-15
Vendor ID:                               ARM
Model name:                              Neoverse-V2
Model:                                   1
Thread(s) per core:                      1
Core(s) per cluster:                     16
Socket(s):                               -
Cluster(s):                              1
Stepping:                                r0p1
BogoMIPS:                                2000.00
Flags:                                   fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache:                               1 MiB (16 instances)
L1i cache:                               1 MiB (16 instances)
L2 cache:                                32 MiB (16 instances)
L3 cache:                                80 MiB (1 instance)
NUMA node(s):                            1
NUMA node0 CPU(s):                       0-15
Vulnerability Gather data sampling:      Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit:             Not affected
Vulnerability L1tf:                      Not affected
Vulnerability Mds:                       Not affected
Vulnerability Meltdown:                  Not affected
Vulnerability Mmio stale data:           Not affected
Vulnerability Reg file data sampling:    Not affected
Vulnerability Retbleed:                  Not affected
Vulnerability Spec rstack overflow:      Not affected
Vulnerability Spec store bypass:         Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:                Mitigation; __user pointer sanitization
Vulnerability Spectre v2:                Mitigation; CSV2, BHB
Vulnerability Srbds:                     Not affected
Vulnerability Tsa:                       Not affected
Vulnerability Tsx async abort:           Not affected
Vulnerability Vmscape:                   Not affected
Details

Comparing HEAD and feat_21784-has-true-has-false
--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query     ┃                                  HEAD ┃         feat_21784-has-true-has-false ┃        Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 0  │          1.17 / 4.68 ±6.90 / 18.47 ms │          1.16 / 4.65 ±6.83 / 18.31 ms │     no change │
│ QQuery 1  │        12.40 / 12.78 ±0.22 / 13.06 ms │        12.60 / 13.03 ±0.24 / 13.32 ms │     no change │
│ QQuery 2  │        37.06 / 37.45 ±0.25 / 37.77 ms │        37.45 / 38.85 ±1.35 / 41.15 ms │     no change │
│ QQuery 3  │        31.69 / 32.87 ±1.40 / 35.24 ms │        31.35 / 32.48 ±1.66 / 35.74 ms │     no change │
│ QQuery 4  │     248.68 / 250.66 ±2.10 / 254.54 ms │     239.74 / 243.91 ±2.85 / 248.51 ms │     no change │
│ QQuery 5  │     285.62 / 286.56 ±0.88 / 288.11 ms │     283.27 / 285.82 ±2.02 / 289.11 ms │     no change │
│ QQuery 6  │          6.78 / 8.15 ±1.87 / 11.84 ms │           6.77 / 7.29 ±0.44 / 7.85 ms │ +1.12x faster │
│ QQuery 7  │        13.88 / 14.07 ±0.10 / 14.18 ms │        14.49 / 14.64 ±0.19 / 15.01 ms │     no change │
│ QQuery 8  │     330.53 / 333.94 ±2.12 / 337.07 ms │     331.43 / 332.29 ±0.66 / 333.39 ms │     no change │
│ QQuery 9  │    440.38 / 455.84 ±10.60 / 472.09 ms │    454.44 / 462.78 ±10.69 / 483.71 ms │     no change │
│ QQuery 10 │        73.20 / 74.28 ±0.78 / 75.58 ms │        73.15 / 74.55 ±1.42 / 77.19 ms │     no change │
│ QQuery 11 │        83.55 / 84.73 ±0.70 / 85.49 ms │        84.73 / 87.61 ±4.13 / 95.78 ms │     no change │
│ QQuery 12 │     276.48 / 280.93 ±3.86 / 287.66 ms │     276.37 / 279.94 ±3.14 / 285.21 ms │     no change │
│ QQuery 13 │    395.89 / 403.36 ±10.09 / 423.20 ms │     397.40 / 403.57 ±3.76 / 407.22 ms │     no change │
│ QQuery 14 │     284.37 / 289.00 ±3.06 / 292.69 ms │     289.08 / 294.83 ±3.20 / 297.86 ms │     no change │
│ QQuery 15 │     288.65 / 290.19 ±1.52 / 292.93 ms │     287.20 / 292.83 ±7.94 / 308.46 ms │     no change │
│ QQuery 16 │     625.67 / 629.97 ±3.87 / 635.54 ms │     628.69 / 635.48 ±4.04 / 639.04 ms │     no change │
│ QQuery 17 │     634.51 / 637.93 ±2.29 / 640.79 ms │     629.75 / 634.71 ±4.91 / 642.84 ms │     no change │
│ QQuery 18 │ 1271.87 / 1283.99 ±14.44 / 1309.76 ms │ 1267.37 / 1295.29 ±25.85 / 1343.88 ms │     no change │
│ QQuery 19 │        28.68 / 28.96 ±0.21 / 29.20 ms │        28.61 / 29.47 ±0.66 / 30.51 ms │     no change │
│ QQuery 20 │     518.94 / 526.77 ±7.30 / 537.08 ms │     516.53 / 522.42 ±3.18 / 525.83 ms │     no change │
│ QQuery 21 │    597.19 / 606.36 ±10.97 / 627.55 ms │     598.70 / 601.65 ±2.03 / 604.05 ms │     no change │
│ QQuery 22 │  1057.94 / 1071.42 ±9.45 / 1087.50 ms │  1064.79 / 1070.43 ±5.61 / 1080.21 ms │     no change │
│ QQuery 23 │ 3324.38 / 3355.32 ±18.56 / 3380.59 ms │ 3311.68 / 3345.99 ±25.37 / 3383.53 ms │     no change │
│ QQuery 24 │        41.68 / 43.06 ±1.08 / 44.61 ms │        41.47 / 43.49 ±1.77 / 46.53 ms │     no change │
│ QQuery 25 │     113.54 / 116.20 ±2.87 / 120.59 ms │     113.68 / 115.90 ±1.47 / 117.90 ms │     no change │
│ QQuery 26 │        42.47 / 43.77 ±1.42 / 46.51 ms │        42.49 / 44.25 ±1.55 / 47.15 ms │     no change │
│ QQuery 27 │     671.37 / 677.83 ±5.17 / 687.10 ms │     671.77 / 676.67 ±4.77 / 684.94 ms │     no change │
│ QQuery 28 │ 3017.20 / 3037.47 ±11.19 / 3051.51 ms │ 3015.63 / 3036.05 ±20.87 / 3072.43 ms │     no change │
│ QQuery 29 │        42.74 / 49.40 ±8.99 / 65.93 ms │        42.80 / 48.63 ±9.20 / 66.75 ms │     no change │
│ QQuery 30 │     313.43 / 316.70 ±3.27 / 321.58 ms │     312.35 / 318.99 ±6.82 / 329.19 ms │     no change │
│ QQuery 31 │     310.41 / 317.18 ±5.84 / 327.78 ms │     309.51 / 314.39 ±4.11 / 319.51 ms │     no change │
│ QQuery 32 │ 1019.35 / 1035.40 ±16.15 / 1065.60 ms │  1019.33 / 1024.97 ±7.50 / 1039.66 ms │     no change │
│ QQuery 33 │  1440.40 / 1457.11 ±9.07 / 1465.50 ms │ 1435.65 / 1461.02 ±15.89 / 1481.00 ms │     no change │
│ QQuery 34 │ 1458.14 / 1478.44 ±29.45 / 1536.76 ms │ 1463.76 / 1482.62 ±19.55 / 1519.68 ms │     no change │
│ QQuery 35 │    296.70 / 321.76 ±28.89 / 377.32 ms │    293.15 / 309.19 ±24.06 / 356.06 ms │     no change │
│ QQuery 36 │        62.52 / 67.75 ±3.26 / 71.99 ms │        63.23 / 68.19 ±4.25 / 75.76 ms │     no change │
│ QQuery 37 │        35.76 / 38.67 ±4.59 / 47.68 ms │        36.39 / 40.86 ±5.57 / 51.24 ms │  1.06x slower │
│ QQuery 38 │        40.80 / 44.97 ±3.37 / 49.52 ms │        43.69 / 47.03 ±3.85 / 54.33 ms │     no change │
│ QQuery 39 │     133.39 / 137.36 ±3.90 / 142.49 ms │     124.34 / 133.36 ±5.30 / 140.19 ms │     no change │
│ QQuery 40 │        14.49 / 15.00 ±0.34 / 15.54 ms │        14.53 / 15.62 ±1.76 / 19.12 ms │     no change │
│ QQuery 41 │        13.77 / 15.37 ±2.69 / 20.74 ms │        13.91 / 14.20 ±0.24 / 14.61 ms │ +1.08x faster │
│ QQuery 42 │        13.67 / 14.88 ±2.07 / 19.01 ms │        13.55 / 13.73 ±0.18 / 14.05 ms │ +1.08x faster │
└───────────┴───────────────────────────────────────┴───────────────────────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary                            ┃            ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD)                            │ 20228.58ms │
│ Total Time (feat_21784-has-true-has-false)   │ 20213.69ms │
│ Average Time (HEAD)                          │   470.43ms │
│ Average Time (feat_21784-has-true-has-false) │   470.09ms │
│ Queries Faster                               │          3 │
│ Queries Slower                               │          1 │
│ Queries with No Change                       │         39 │
│ Queries with Failure                         │          0 │
└──────────────────────────────────────────────┴────────────┘

Resource Usage

clickbench_partitioned — base (merge-base)

Metric Value
Wall time 105.0s
Peak memory 31.1 GiB
Avg memory 23.2 GiB
CPU user 1068.8s
CPU sys 64.1s
Peak spill 0 B

clickbench_partitioned — branch

Metric Value
Wall time 105.0s
Peak memory 29.1 GiB
Avg memory 22.9 GiB
CPU user 1068.4s
CPU sys 65.9s
Peak spill 0 B

File an issue against this benchmark runner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

datasource Changes to the datasource crate functions Changes to functions implementation physical-expr Changes to the physical-expr crates physical-plan Changes to the physical-plan crate spark

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace true_count() and false_count() with has_true() and has_false()

3 participants