Open
Conversation
nathanb9
reviewed
Apr 23, 2026
| /// * [`TrackConsumersPool`]: Wraps another [`MemoryPool`] and tracks consumers, | ||
| /// providing better error messages on the largest memory users. | ||
| pub trait MemoryPool: Send + Sync + std::fmt::Debug + Display { | ||
| pub trait MemoryPool: Any + Send + Sync + std::fmt::Debug + Display { |
Contributor
There was a problem hiding this comment.
Adding Any as a supertrait adds a 'static requirement to every MemoryPool implementor. This might break downstream if they have implemented custom pools which borrowed state or lifetime parameters
Contributor
Author
There was a problem hiding this comment.
thank you for mention this, i add upgrade guide in 344b52f
nathanb9
approved these changes
Apr 23, 2026
github-actions
Bot
added
the
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
implment Any for MemoryPool
Are these changes tested?
yes, add one test case
Are there any user-facing changes?