Skip to content

fix off-by-one rejecting trailing nan/infinity in parseNumber #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aherbert merged 2 commits into from
Jun 9, 2026
+30 −1
Merged

fix off-by-one rejecting trailing nan/infinity in parseNumber #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af3bde3
fix off-by-one rejecting trailing nan/infinity in parseNumber
dxbjavid Jun 8, 2026
e0bee2b
add round-trip and imaginary-part special value parse tests
dxbjavid Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion commons-math-legacy/src/main/java/org/apache/commons/math4/legacy/util/CompositeFormat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ private static Number parseNumber(final String source, final double value,
final int n = sb.length();
final int startIndex = pos.getIndex();
final int endIndex = startIndex + n;
if (endIndex < source.length() &&
if (endIndex <= source.length() &&
source.substring(startIndex, endIndex).compareTo(sb.toString()) == 0) {
ret = Double.valueOf(value);
pos.setIndex(endIndex);
Expand Down
29 changes: 29 additions & 0 deletions ...-legacy/src/test/java/org/apache/commons/math4/legacy/util/ComplexFormatAbstractTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,35 @@ public void testPaseNegativeInfinity() {
Assert.assertEquals(expected, actual);
}

@Test
public void testParseRealNan() {
// a real-only special value runs to the last character of the string
Complex expected = Complex.ofCartesian(Double.NaN, 0);
Assert.assertEquals(expected, complexFormat.parse("(NaN)"));
Assert.assertEquals(expected, complexFormat.parse(complexFormat.format(expected)));
}

@Test
public void testParseRealInfinity() {
Complex positive = Complex.ofCartesian(Double.POSITIVE_INFINITY, 0);
Assert.assertEquals(positive, complexFormat.parse("(Infinity)"));
Assert.assertEquals(positive, complexFormat.parse(complexFormat.format(positive)));
Complex negative = Complex.ofCartesian(Double.NEGATIVE_INFINITY, 0);

@aherbert aherbert Jun 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should test the round-trip:

Assert.assertEquals(positive, complexFormat.parse(complexFormat.format(positive)));
Assert.assertEquals(negative, complexFormat.parse(complexFormat.format(negative)));

Parsing should also test special values in the imaginary part:

Complex.ofCartesian(1.23, Double.NaN);
Complex.ofCartesian(1.23, Double.POSITIVE_INFINITY);
Complex.ofCartesian(1.23, Double.NEGATIVE_INFINITY);

@dxbjavid dxbjavid Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. The infinity test now checks the round trip for both signs, and I added testParseImaginarySpecialValue covering NaN, +Infinity and -Infinity in the imaginary part (parsed back from format output). All pass with the patch.

Assert.assertEquals(negative, complexFormat.parse("(-Infinity)"));
Assert.assertEquals(negative, complexFormat.parse(complexFormat.format(negative)));
}

@Test
public void testParseImaginarySpecialValue() {
// the special value sits in the imaginary part, ahead of the imaginary character
Complex nan = Complex.ofCartesian(1.23, Double.NaN);
Assert.assertEquals(nan, complexFormat.parse(complexFormat.format(nan)));
Complex positive = Complex.ofCartesian(1.23, Double.POSITIVE_INFINITY);
Assert.assertEquals(positive, complexFormat.parse(complexFormat.format(positive)));
Complex negative = Complex.ofCartesian(1.23, Double.NEGATIVE_INFINITY);
Assert.assertEquals(negative, complexFormat.parse(complexFormat.format(negative)));
}

@Test
public void testConstructorSingleFormat() {
NumberFormat nf = NumberFormat.getInstance();
Expand Down
Loading