Skip to content

FIx yaml doc generation#38874

Merged
Abacn merged 1 commit into
apache:masterfrom
Abacn:fix-yaml-doc
Jun 9, 2026
Merged

FIx yaml doc generation#38874
Abacn merged 1 commit into
apache:masterfrom
Abacn:fix-yaml-doc

Conversation

@Abacn

@Abacn Abacn commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Fix #34694

Re-generated doc in apache/beam-site#706

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the YAML documentation generation process by refactoring the dependency management for expansion services. By creating a dedicated task to prepare and cache these services, the build process becomes more robust and maintainable. Additionally, it cleans up unused configuration properties in the standard YAML definitions.

Highlights

  • YAML Documentation Generation: Introduced a new Gradle task 'prepareExpansionServicesForYamlDocs' to centralize the building and caching of expansion services required for YAML documentation generation.
  • Configuration Cleanup: Removed the 'append_batch_size' property from the standard YAML configuration definition.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the append_batch_size property from standard_io.yaml and introduces a new Gradle task, prepareExpansionServicesForYamlDocs, to build and cache expansion service JARs. A critical issue was identified in the Gradle copy task where passing task path strings directly to the from method will not resolve to the task's output files, resulting in no files being copied. It is recommended to use project.tasks.findByPath(...) to correctly reference the tasks and copy their outputs.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread sdks/python/build.gradle
Comment thread sdks/python/apache_beam/yaml/standard_io.yaml
@Abacn

Abacn commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

R: @jrmccluskey @derrickaw

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Abacn Abacn merged commit 3b104b6 into apache:master Jun 9, 2026
107 checks passed
@Abacn Abacn deleted the fix-yaml-doc branch June 9, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Beam YAML documentation not reflecting full parameters.

2 participants