Fix Supervisor crash in Stackdriver remote log IO#68295
Open
23tae wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents the Airflow 3 Supervisor process from crashing entirely when transient network or IAM errors occur during Stackdriver log transmission.
Description
This PR addresses Bug 3 described in #68240.
In the new Airflow 3 Task SDK architecture, the
StackdriverRemoteLogIOhandler runs within the Supervisor process rather than the task process itself. If an exception is raised during_transport.send(), it propagates upwards and crashes the entire Supervisor process, disrupting task monitoring.Key changes
_transport.send()call in atry...except Exceptionblock. When a transmission fails, the exception is safely caught, and a warning is logged using the internal_logger. This ensures the Supervisor process remains highly resilient.Verification Results
I have verified the changes using
prekandbreeze.related: #68240
Was generative AI tooling used to co-author this PR?
Generated-by: Antigravity following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.