Fix UI instance name title on non-Dag pages#68288
Draft
hkc-8010 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #68287.
Restores the configured
[api] instance_nameas the default browser tab title for non-Dag pages such as the home page.Dag-specific pages using
useDocumentTitle(...)still override the default title and render as<page title> - <instance_name>.Tests
cd airflow-core/src/airflow/ui && pnpm install --frozen-lockfilecd airflow-core/src/airflow/ui && pnpm exec vitest run src/layouts/BaseLayout.test.tsxcd airflow-core/src/airflow/ui && npx -y -p node@22 node ./node_modules/vitest/vitest.mjs runcd airflow-core/src/airflow/ui && pnpm lintprek run --files airflow-core/src/airflow/ui/src/layouts/BaseLayout.tsx airflow-core/src/airflow/ui/src/layouts/BaseLayout.test.tsx airflow-core/src/airflow/ui/src/utils/index.ts airflow-core/src/airflow/ui/src/utils/useDocumentTitle.tsxbreeze ui compile-assetsGenAI Disclosure
This PR was developed with assistance from OpenAI Codex.