Skip to content

fix(core): sanitize object keys in deepCopy to prevent prototype pollution #33049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XananasX7 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

fix(core): sanitize object keys in deepCopy to prevent prototype pollution #33049

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/angular_devkit/core/src/utils/object.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,18 @@ export function deepCopy<T>(value: T): T {

const copy = Object.create(Object.getPrototypeOf(valueCasted));
valueCasted[copySymbol] = copy;

for (const key of Object.getOwnPropertyNames(valueCasted)) {
// 🛡️ SECURITY CHECK FIRST: Block prototype pollution keys
if (key === '__proto__' || key === 'constructor' || key === 'prototype') {
continue;
}

// Now it is safe to copy
copy[key] = deepCopy(valueCasted[key]);
}

delete valueCasted[copySymbol];

return copy;
} else {
return value;
Expand Down
Loading