feat(console-web): strengthen team action handoffs#662
Merged
Conversation
9 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## dev #662 +/- ##
==========================================
- Coverage 72.13% 72.13% -0.01%
==========================================
Files 1261 1261
Lines 91065 91065
Branches 11924 11924
==========================================
- Hits 65691 65687 -4
- Misses 20675 20676 +1
- Partials 4699 4702 +3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Team Detail could surface attention states, but the handoff from attention to action was still incomplete. Waiting or failed runs did not preserve the concrete run identity when opening Runs, and binding/deployment actions were not available from the top Team operation loop.
Solution
runIdsupport tobuildRuntimeRunsHrefso Team and other callers can deep-link into the exact run context.Impact Paths
apps/aevatar-console-web/src/pages/teams/detail.tsxapps/aevatar-console-web/src/pages/teams/home.tsxapps/aevatar-console-web/src/pages/teams/components/TeamDetailChrome.tsxapps/aevatar-console-web/src/shared/navigation/runtimeRoutes.tsVerification
npm --prefix apps/aevatar-console-web run test -- --runInBand src/pages/teams/home.test.tsx src/pages/teams/detail.test.tsx src/pages/teams/runtime/teamRuntimeLens.test.ts src/shared/navigation/teamRoutes.test.ts src/shared/navigation/runtimeRoutes.test.tsnpm --prefix apps/aevatar-console-web run tscnpm --prefix apps/aevatar-console-web run buildgit diff --checkCloses #656