feat(console-web): finish Studio member identity routing#658
Open
potter-sun wants to merge 2 commits into
Open
feat(console-web): finish Studio member identity routing#658potter-sun wants to merge 2 commits into
potter-sun wants to merge 2 commits into
Conversation
8 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## dev #658 +/- ##
==========================================
- Coverage 72.13% 72.13% -0.01%
==========================================
Files 1261 1261
Lines 91065 91065
Branches 11924 11924
==========================================
- Hits 65690 65689 -1
- Misses 20675 20676 +1
Partials 4700 4700
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…e-web-member-identity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Studio route state still treated legacy service-backed
memberIdvalues as if they were canonical member identity. That made old service links useful, but it also allowed service ids to leak into member selection, Team return links, and lifecycle surfaces.Closes #652
Solution
member=member:<id>as the canonical Studio member route identity.memberId=<serviceId>as an explicit compatibility token and canonicalize it to the real member id once the roster/service mapping is known.studioApi.getMember(scope, serviceId)before canonicalization.Verification
git diff --checknpm --prefix apps/aevatar-console-web run test -- --runInBand src/pages/studio/index.test.tsx -t "carries the selected bind contract|shows an invoke empty state|opens the Studio invoke surface|walks the lifecycle flow"npm --prefix apps/aevatar-console-web run test -- --runInBand src/pages/studio/index.test.tsx src/shared/studio/navigation.test.ts src/pages/teams/detail.test.tsxnpm --prefix apps/aevatar-console-web run tscnpm --prefix apps/aevatar-console-web run buildNotes: Jest emits existing React
act(...)and Watchman recrawl warnings; all targeted suites passed. The focused Biome lint command reports pre-existing warnings in the touched files and no errors.