Skip to content

chore: fix npm dependency vulnerabilities (undici, fast-xml-builder)#1564

Open
yuzurihaaa wants to merge 5 commits into
actions:mainfrom
yuzurihaaa:chore/bump-actions-github
Open

chore: fix npm dependency vulnerabilities (undici, fast-xml-builder)#1564
yuzurihaaa wants to merge 5 commits into
actions:mainfrom
yuzurihaaa:chore/bump-actions-github

Conversation

@yuzurihaaa

@yuzurihaaa yuzurihaaa commented Jun 4, 2026

Copy link
Copy Markdown

Description

This PR addresses security vulnerabilities identified by Snyk in transitive dependencies.

Upgraded @actions/github from 6.0.1 to 8.0.1 — eliminates 5 vulnerabilities in undici@5.29.0:

  • Improper Handling of Highly Compressed Data / Data Amplification (High)
  • Uncaught Exception (High)
  • Allocation of Resources Without Limits or Throttling (Medium)
  • HTTP Request Smuggling (Medium)
  • CRLF Injection (Medium)

Updated fast-xml-builder in package-lock.json to a patched version — resolves 2 vulnerabilities introduced transitively via @actions/cache > @azure/storage-blob > @azure/core-xml > fast-xml-parser > fast-xml-builder@1.1.4:

  • XML Injection (Medium) — fixed in 1.1.5
  • XML External Entity (XXE) Injection (Medium) — fixed in 1.1.7

Before / After:

State Issues Vulnerable Paths
Before 8 14
After (this PR) 1 2

The only remaining issue is @actions/glob@0.5.1 ReDoS (Medium) — no upstream fix is currently available.

Related issue

There are also another PR on fast-xml-builder. This combines the PR and @actions/github package bump.

Check list

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

Others

npm run test

Screenshot 2026-06-04 at 12 03 07 PM

npm run build
Screenshot 2026-06-04 at 12 04 30 PM

@yuzurihaaa yuzurihaaa requested a review from a team as a code owner June 4, 2026 03:44
yuzurihaaa and others added 2 commits June 4, 2026 11:52
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
@yuzurihaaa

Copy link
Copy Markdown
Author

Sample run to validate dist/ https://github.com/yuzurihaaa/setup-node/actions/runs/26941635120

Comment thread package.json
"@actions/core": "^2.0.3",
"@actions/exec": "^2.0.0",
"@actions/github": "^6.0.1",
"@actions/github": "^8.0.1",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Would it make sense to directly upgrade to 9.1.1?

The Breaking Change doesn't seem to apply to this repo: https://github.com/actions/toolkit/blob/main/packages/github/RELEASES.md#900

@yuzurihaaa yuzurihaaa Jun 10, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do want to bump to 9.x but the build will fail. You can refer to this PR #1532 too dependabot bumping to 9.x but failed on CI

Error: Module not found: Error: Package path . is not exported from package /Users/runner/work/setup-node/setup-node/node_modules/@actions/github (see exports field in /Users/runner/work/setup-node/setup-node/node_modules/@actions/github/package.json)
Did you mean './@actions/github'?
Requests that should resolve in the current directory need to start with './'.
Requests that start with a name are treated as module requests and resolve within module directories (node_modules).
If changing the source code is not an option there is also a resolve options called 'preferRelative' which tries to resolve these kind of requests in the current directory too.
    at /Users/runner/work/setup-node/setup-node/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:23:2001849
    at /Users/runner/work/setup-node/setup-node/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:23:389111
    at _done (eval at create (/Users/runner/work/setup-node/setup-node/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:21:81694), <anonymous>:9:1)
    at eval (eval at create (/Users/runner/work/setup-node/setup-node/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:21:81694), <anonymous>:34:22)

Initially I filed an issue on this, but my goal is to resolve the vulnerabilities reported in my org so this this is the minimum viable change. I do have a branch that upgrade to 9.x but I had to change the build script to use esbuild.

@yuzurihaaa

yuzurihaaa commented Jun 10, 2026

Copy link
Copy Markdown
Author

on an almost related note. I necro-ed a PR (through my PR) to resolve another vulnerability if someone can review the PR. I can help to do the follow up PR.

@yuzurihaaa yuzurihaaa requested a review from deiga June 10, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants