fix(proto-utils): use FieldDescriptor.is_repeated instead of removed .label#1042
Open
sonirico wants to merge 2 commits intoa2aproject:mainfrom
Open
fix(proto-utils): use FieldDescriptor.is_repeated instead of removed .label#1042sonirico wants to merge 2 commits intoa2aproject:mainfrom
sonirico wants to merge 2 commits intoa2aproject:mainfrom
Conversation
….label protobuf 7.x dropped FieldDescriptor.label from both upb and pure-Python backends, breaking all three call sites in proto_utils.py at runtime: AttributeError: 'FieldDescriptor' object has no attribute 'label' The code already had TODO comments referencing a2aproject#1011 with the exact intended fix ("Replace deprecated `field.label` with `field.is_repeated` once the minimum protobuf version requirement is bumped"). Since the package's protobuf>=5.29.5 floor is well past the version that exposed both attributes, we can land the swap now. Three call sites: - parse_query_params_to_proto (line 180): body request parsing - _check_required_field_violation (line 217): required-field validator - _recurse_validation (line 261): nested-message validator Without this fix, every JSON-RPC method that runs through the request handler raises AttributeError before the agent executor is ever called. Closes a2aproject#1011
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates src/a2a/utils/proto_utils.py by replacing the deprecated field.label attribute with the field.is_repeated property across several functions, including parse_params, _check_required_field_violation, and _recurse_validation. These changes resolve existing TODOs and align the code with modern protobuf standards. I have no feedback to provide.
🧪 Code Coverage (vs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three call sites in
proto_utils.pyuseFieldDescriptor.label, which protobuf 7.x removed from both the upb and pure-Python backends. Every JSON-RPC method that runs through the request handler raisesAttributeErrorbefore the agent executor is ever called:The code already had TODOs referencing #1011 with the exact intended fix ("Replace deprecated
field.labelwithfield.is_repeatedonce the minimum protobuf version requirement is bumped"). Since the package'sprotobuf>=5.29.5floor is well past the version that supportsis_repeated, we can land the swap now.Changes
parse_query_params_to_proto(was line 180): body request parsing_check_required_field_violation(was line 217): required-field validator_recurse_validation(was line 261): nested-message validatorEach
field.label == FieldDescriptor.LABEL_REPEATEDbecomesfield.is_repeated, and the inverse!=becomesnot field.is_repeated. The corresponding TODO comments are removed.Test plan
validate_proto_required_fieldsfails on protobuf 7.34.1 againsta2a-sdk==1.0.2without the patchmessage/send,tasks/get,agent/getAuthenticatedExtendedCardall return correctlytests/utils/test_proto_utils.pyandtests/compat/v0_3/test_proto_utils.pysuites, which should still pass (the change is semantically equivalent on protobuf versions that have both attributes)Closes #1011