Skip to content

test: setup itk resubscribe tests#1031

Open
kdziedzic70 wants to merge 1 commit intomainfrom
dziedzick/setup-itk-resubscribe-tests
Open

test: setup itk resubscribe tests#1031
kdziedzic70 wants to merge 1 commit intomainfrom
dziedzick/setup-itk-resubscribe-tests

Conversation

@kdziedzic70
Copy link
Copy Markdown
Contributor

@kdziedzic70 kdziedzic70 commented Apr 30, 2026

Description

PR adjusts itk tests with resubscribe behavior check

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests and linter pass (Run bash scripts/format.sh from the repository root to format)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@kdziedzic70 kdziedzic70 requested a review from a team as a code owner April 30, 2026 09:41
Comment thread itk/main.py Fixed
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces 'resubscribe' and 'hold task' behaviors to the ITK agent, adds helper functions for event and task management, and improves resource handling via an asynchronous context manager for the HTTP client. It also implements signal handling for graceful shutdowns, updates agent capabilities, and expands the test suite. Feedback was provided to correct Protobuf field presence checks and enum comparisons, remove a deprecated parameter, and restore configurable logging for the uvicorn server.

Comment thread itk/main.py Outdated
Comment thread itk/main.py Outdated
Comment thread itk/main.py
Comment thread itk/main.py Outdated
@kdziedzic70 kdziedzic70 force-pushed the dziedzick/setup-itk-resubscribe-tests branch 4 times, most recently from 751ae20 to 0d03c79 Compare May 4, 2026 09:34
@kdziedzic70 kdziedzic70 changed the title [WIP]test: setup itk resubscribe tests test: setup itk resubscribe tests May 4, 2026
@kdziedzic70 kdziedzic70 force-pushed the dziedzick/setup-itk-resubscribe-tests branch from 0d03c79 to 6a923e7 Compare May 4, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant