refactor: lowercase channel factory across subworkflows + workflows#504
Open
tpall wants to merge 1 commit intoWrightonLabCSU:devfrom
Open
refactor: lowercase channel factory across subworkflows + workflows#504tpall wants to merge 1 commit intoWrightonLabCSU:devfrom
channel factory across subworkflows + workflows#504tpall wants to merge 1 commit intoWrightonLabCSU:devfrom
Conversation
DSL2 prefers the lowercase `channel` factory function over the
`Channel` class qualifier — both work but the lowercase form is the
documented default and is a one-character net win on every line that
constructs a channel. Pure cosmetic refactor, no behaviour change.
Touches all sites currently using `Channel.empty`, `Channel.fromPath`,
etc. across:
subworkflows/local/{call,collect_rna,db_search,merge,qc,
utils_nfcore_dram_pipeline}.nf
workflows/dram.nf
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pure cosmetic refactor: switch from the
Channelclass qualifier to the lowercasechannelfactory function across all subworkflows + workflows. Both forms work in DSL2; lowercasechannelis the documented default and the more common style in modern nf-core pipelines.This was one of the changes bundled into the now-closed #472 per @madeline-scyphers' note ("thanks for some of the other QoL updates like updating some of the syntax to DSL2 (Channel -> channel, etc.)"). Splitting it out into its own PR per the maintainer-friendly path agreed when refiling #503.
What changed
+42 / -42 lines, 7 files, mechanicalChannel.X→channel.Xsubstitution wherever a channel factory is used:Test plan
channelandChannelresolve to the same Nextflow factory in DSL2.git diff --statshows equal+/-counts (one-for-one substitution).devif you'd like a smoke run before merge.🤖 Generated with Claude Code