Plugin Directory: Send plugin updates to Gandalf for advisory scans#633
Draft
Luc45 wants to merge 8 commits into
Draft
Plugin Directory: Send plugin updates to Gandalf for advisory scans#633Luc45 wants to merge 8 commits into
Luc45 wants to merge 8 commits into
Conversation
6 tasks
bazza
pushed a commit
that referenced
this pull request
May 13, 2026
Props dd32. Closes #634. git-svn-id: https://meta.svn.wordpress.org/sites/trunk@14870 74240141-8908-4e6f-9713-ba540dce6ec7
bazza
pushed a commit
that referenced
this pull request
May 13, 2026
…> Plugin_Scan rename in Upload_Handler. [14871] reverted [14870] unintentionally. Props lucasbustamante, dd32. Closes #633. git-svn-id: https://meta.svn.wordpress.org/sites/trunk@14872 74240141-8908-4e6f-9713-ba540dce6ec7
Member
|
Re-opening this, as I committed (badly) a variant of this via #634, but with greatly less error handling checks. I didn't see the point in being super strict on the payloads here, when it's only an internal service that's being called / responding. This allows for a more gracious path going forward where the payloads can be updated independently without having to be super-strict about needing to be updated in the same second. It might also best to update the scanner to accept any WordPress.org ZIP url as well, including our CDN's, as I'd have liked to include the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a plugin import, carry the importer release context through the existing
scan_plugin:{slug}cron job and send the current ZIP URL to Gandalf.Gandalf callbacks are accepted through a new authenticated REST route. The Plugin Directory keeps only local integration state: pending scan correlation, latest integration error, and Slack verdict dedupe. Full scan history and reports stay in Gandalf.
This is advisory only for now, so that we can monitor false positive rate. Plugin releases are not blocked if Gandalf is unavailable or returns findings.
Reuses the existing Plugin Check cron path rather than adding a second per-plugin update scan cron job.
Testing: